bump: replaces golang/mock with a maintained uber-go fork#13933
Open
chandler-solo wants to merge 2 commits intokgateway-dev:mainfrom
Open
bump: replaces golang/mock with a maintained uber-go fork#13933chandler-solo wants to merge 2 commits intokgateway-dev:mainfrom
chandler-solo wants to merge 2 commits intokgateway-dev:mainfrom
Conversation
Signed-off-by: David L. Chandler <david.chandler@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Go mocking tooling by migrating from the unmaintained github.com/golang/mock to the maintained fork at go.uber.org/mock, aligning both test imports and mock generation.
Changes:
- Switch test code imports from
github.com/golang/mock/gomocktogo.uber.org/mock/gomock. - Update the
//go:generatemockgen invocation and regenerate affected mocks using the Uber fork. - Update module dependencies and tool declarations in
go.mod/go.sumaccordingly.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/kgateway/translator/listener/gateway_listener_translator_test.go | Updates gomock import to go.uber.org/mock/gomock. |
| pkg/kgateway/translator/httproute/translate_httproute_test.go | Updates gomock import to go.uber.org/mock/gomock. |
| pkg/kgateway/query/query_test.go | Updates //go:generate to use go.uber.org/mock/mockgen. |
| pkg/kgateway/query/mocks/mock_queries.go | Regenerated mock to use Uber gomock and updated generator header. |
| go.mod | Removes github.com/golang/mock, adds go.uber.org/mock, updates tool directive to go.uber.org/mock/mockgen. |
| go.sum | Removes old golang/mock sums and adds sums for go.uber.org/mock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces golang/mock with a maintained uber-go fork. See golang/mock@674a1c4
Change Type
/kind bump
Changelog
Additional Notes