[2.2] upgrade envoy to v1.36.6#13921
Open
andy-fong wants to merge 3 commits intokgateway-dev:v2.2.xfrom
Open
Conversation
Signed-off-by: Andy Fong <andy.fong@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s Envoy-related artifacts to Envoy v1.36.6.
Changes:
- Bumped the default Envoy wrapper image used by validation to
ghcr.io/kgateway-dev/envoy-wrapper:v2.2.3. - Updated build-time Envoy image tags in the root
Makefiletov1.36.6/1.36.6-patch1. - Updated the Rust dynamic-modules SDK git revision to align with Envoy v1.36.6.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/validator/validator.go | Updates the default Envoy wrapper image tag used for docker-based validation. |
| internal/envoyinit/rustformations/Cargo.toml | Bumps the Envoy Rust SDK git rev to match Envoy v1.36.6. |
| Makefile | Updates ARM64/AMD64 Envoy image tags used for builds and CI docker targets. |
|
|
||
| # ENVOY_IMAGE is used by some of the *-docker targets which are used by CI e2e tests, so figure out the correct image | ||
| # ENVOY_IMAGE is used by some of the *-docker targets which are used by CI e2e tests, so figure out the correct image | ||
| # to use base on GOARCH. This doesn't affect goreleaser |
There was a problem hiding this comment.
The Makefile comment has a grammatical typo: “to use base on GOARCH” should be “to use based on GOARCH” (or reworded) for clarity.
Suggested change
| # to use base on GOARCH. This doesn't affect goreleaser | |
| # to use based on GOARCH. This doesn't affect goreleaser |
Comment on lines
11
to
14
| [target.'cfg(not(target_arch = "x86_64"))'.dependencies] | ||
| # The SDK version must match the Envoy version due to the strict compatibility requirements. | ||
| envoy-sdk-remote = { package = "envoy-proxy-dynamic-modules-rust-sdk", git = "https://github.com/envoyproxy/envoy", rev = "41749943780b54b70b510b1b1a4805ae529e174a" } # envoy v1.36.5 | ||
| envoy-sdk-remote = { package = "envoy-proxy-dynamic-modules-rust-sdk", git = "https://github.com/envoyproxy/envoy", rev = "31608367a7f5f7e4ec627f4dac396577f2322fdc" } # envoy v1.36.6 | ||
|
|
There was a problem hiding this comment.
Cargo.toml updates the Envoy SDK git rev to v1.36.6, but internal/envoyinit/Cargo.lock still references the previous rev (4174994…). Please regenerate/commit the lockfile so builds don’t silently modify Cargo.lock (and so CI uses the intended dependency revision).
Signed-off-by: Andy Fong <andy.fong@solo.io>
Signed-off-by: Andy Fong <andy.fong@solo.io>
jenshu
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgraded envoy to v1.36.6
Change Type
/kind bump
Changelog