fix(core): remediate validation feedback loss and access control regressions#9840
Open
envsecure wants to merge 2 commits into
Open
fix(core): remediate validation feedback loss and access control regressions#9840envsecure wants to merge 2 commits into
envsecure wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a comprehensive fix for the critical regressions in the KeystoneJS core that were identified in CI logs following the submission of PR #9838. It essentially replaces and completes the work started in #9838 by addressing the specific failure cases found in automated testing.
Key Improvements:
Validation Pipeline Restoration:
validatetovalidateInput. This is a crucial fix for the API test suite which explicitly matches on thevalidateInputtag.hooks.tsto resolveMISSING_EXPORTbuild errors encountered with Rollup/Preconstruct.Access Control Robustness:
checkUniqueItemExiststo correctly handle lists that are hidden from the GraphQL schema due to access control.CI & Formatting:
hooks.tsto strictly adhere to the KeystoneJS "no semicolon" and trailing newline rules, resolving theformat:checkfailures.Changes
packages/core/src/lib/core/hooks.ts: Fixed types, formatting, and error tags.packages/core/src/lib/core/access-control.ts: Improved error handling for unique item checks..changeset/remediate-ci-failures.md: Added documentation for the patch.Relation to Previous Work