Skip to content

maint(core): exclude .configured files from source tarball 🏗️#15928

Merged
ermshiperete merged 1 commit into
masterfrom
maint/core/15905_build
May 11, 2026
Merged

maint(core): exclude .configured files from source tarball 🏗️#15928
ermshiperete merged 1 commit into
masterfrom
maint/core/15905_build

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

In the source tarball we don't want to include .configured files so that a build will call npm i first.

Fixes: #15905
Follows: #15926
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S28 milestone May 7, 2026
@github-actions github-actions Bot added linux/ core/ Keyman Core maint Maintenance work -- continuous integration, build scripts, infrastructure labels May 7, 2026
In the source tarball we don't want to include `.configured` files so
that a build will call `npm i` first.

Fixes: #15905
Follows: #15926
Test-bot: skip
@ermshiperete ermshiperete force-pushed the maint/core/15905_build branch from 6fdd138 to 69db9e9 Compare May 7, 2026 17:06
@ermshiperete ermshiperete marked this pull request as ready for review May 7, 2026 17:10
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, esp. since it should have been npm ci rather than npm i!

ermshiperete added a commit that referenced this pull request May 8, 2026
This change adds a retry mechanism for failed uploads to Launchpad. By
default it tries 5 times.

Follows: #15928
Build-bot: skip
Test-bot: skip
ermshiperete added a commit that referenced this pull request May 8, 2026
This change adds a retry mechanism for failed uploads to Launchpad. By
default it tries 5 times.

Follows: #15928
Build-bot: skip
Test-bot: skip
ermshiperete added a commit that referenced this pull request May 8, 2026
This change adds a retry mechanism for failed uploads to Launchpad. By
default it tries 5 times.

Follows: #15928
Build-bot: skip
Test-bot: skip
ermshiperete added a commit that referenced this pull request May 8, 2026
This change adds a retry mechanism for failed uploads to Launchpad. By
default it tries 5 times.

Follows: #15928
Build-bot: skip
Test-bot: skip
@keyman-server keyman-server modified the milestones: A19S28, A19S29 May 11, 2026
Base automatically changed from chore/linux/projectparam to master May 11, 2026 16:17
@ermshiperete ermshiperete merged commit cef3160 into master May 11, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman May 11, 2026
@ermshiperete ermshiperete deleted the maint/core/15905_build branch May 11, 2026 16:19
ermshiperete added a commit that referenced this pull request May 11, 2026
maint(core): retry upload to launchpad on network failures 🏗️

This change adds a retry mechanism for failed uploads to Launchpad. By default it tries 5 times.

Follows: #15928
ermshiperete added a commit that referenced this pull request May 11, 2026
maint(linux): fix uploading to ppa 🏗️

It seems that since a recent DDOS Launchpad only accepts secure connections. This change uses the new keyman-ppa section (which has already been created on the TC build agents) to upload to the ppa.

Follows: #15928
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.230-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core/ Keyman Core linux/ maint Maintenance work -- continuous integration, build scripts, infrastructure

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

maint(core): ./build.sh configure fails on extracted source tarball

3 participants