Skip to content

[GenericOp] Properly handle slice layouts in MakeRange fusion and unrolled LLVM lowering#461

Open
alexbaden wants to merge 6 commits into
mainfrom
alex/generic_reductions
Open

[GenericOp] Properly handle slice layouts in MakeRange fusion and unrolled LLVM lowering#461
alexbaden wants to merge 6 commits into
mainfrom
alex/generic_reductions

Conversation

@alexbaden

Copy link
Copy Markdown
Contributor

Fixes two bugs which allow all previously failing reduction tests to pass under TileAndFuse.

  • MakeRangeOp fusion now handles nested SliceEncodingAttr layouts
  • Reading slice-encoded tiles in the unrolled path properly reconstructs a full-rank tensor for sliced layouts. The sliced dimension is padded to 1 but the padding is removed in the layout register space. This results in an appropriately ranked tensor, but the value for the padded dimension is ignored - exactly what we want when loading a sliced tile from a sliced global tensor.

I also enabled all reduction tests in GitHub Actions. I used parallel jobs but also bumped the timeout from 60m to 90m, as the addition reduction tests will add a few mins and we were pretty close to 60 to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant