feat: in-place row edits for Arrow tables and GeoJSON layers - #3688
Open
igorDykhta wants to merge 2 commits into
Open
feat: in-place row edits for Arrow tables and GeoJSON layers#3688igorDykhta wants to merge 2 commits into
igorDykhta wants to merge 2 commits into
Conversation
added 2 commits
September 1, 2026 17:47
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Kepler’s in-place row editing flow (addToDataset / removeFromDataset) to work with Arrow-backed datasets (for supported “primitive” Arrow column types), while keeping DuckDB tables as a warned no-op. It also adjusts GeoJSON layer metadata rebuilding so feature parsing stays correct when datasets change via row edits.
Changes:
- Add
append/replace/removesupport toArrowDataContainer, with explicit rejection for nested/binary/geoarrow columns. - Keep DuckDB row edits as a warned no-op at the table layer, and update action/reducer/docs text to reflect Arrow support.
- Rebuild GeoJSON
dataToFeaturewhen row count or table revision changes (not on filter-only updates), plus expand tests and the live-data example to cover Arrow/GeoJSON cases.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/node/utils/duckdb-utils-test.js | Adds coverage ensuring DuckDB row edits remain a warned no-op. |
| test/node/utils/data-container-test.js | Adds unit tests for ArrowDataContainer append/replace/remove semantics and rejection cases. |
| test/node/reducers/vis-state-test.js | Adds integration coverage for Arrow dataset row edits and GeoJSON feature rebuild behavior. |
| src/utils/src/data-container-interface.ts | Updates DataContainerInterface docs to reflect Arrow support for row edits. |
| src/utils/src/arrow-data-container.ts | Implements Arrow in-place row edits with type gating and schema/metadata preservation. |
| src/table/src/kepler-table.ts | Updates table-level row edit behavior/docs; tightens upsert replace failure handling. |
| src/reducers/src/vis-state-updaters.ts | Updates reducer docs to include Arrow behavior and rejection rules. |
| src/layers/src/geojson-layer/geojson-layer.ts | Rebuilds parsed GeoJSON features when row count or meta revision changes. |
| src/layers/src/base-layer.ts | Plumbs trigger-change metadata into updateLayerMeta calls. |
| src/duckdb/src/table/duckdb-table.ts | Adds explicit DuckDB table overrides for row edits that warn + return false. |
| src/actions/src/vis-state-actions.ts | Updates action docs to reflect Arrow support and DuckDB/no-op constraints. |
| src/actions/src/actions.ts | Updates addDataToMap JSDoc to clarify Arrow vs DuckDB behavior. |
| examples/live-data/src/app.tsx | Extends the live-data example to demo CSV vs Arrow vs GeoJSON remounted sessions. |
| examples/live-data/README.md | Documents the new live-data example modes and limitations. |
| docs/api-reference/reducers/vis-state.md | Updates public reducer docs to reflect Arrow support and rejection rules. |
| docs/api-reference/actions/actions.md | Updates public action docs to reflect Arrow support and DuckDB behavior. |
| CHANGELOG.md | Notes Arrow support for row edits and GeoJSON rebuild fix in Unreleased. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addToDataset/removeFromDatasetnow mutate Arrow tables with primitive columns in place (concat append, keyed upsert, slice remove). DuckDB still warns and no-ops until INSERT exists.dataToFeaturewhen the table revision or row count changes, so appended features show on the map. Filter-only updates still skip a re-parse.Test plan
yarn testvis-state + data-container + DuckDB no-opyarn start:live-data→ Arrow: Add / Remove last / Insert then Move tracker (row count stays put)track-01without growing the table