feat: Add nip94 field to upload/mirror responses (BUD-08)#5
Open
kengirie wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nip94array in the blob descriptor JSON returned byPUT /uploadandPUT /mirror.url,m,x,ox,size(NIP-94 string values).oxequalsxsince this server stores blobs verbatim.GET /list/<pubkey>is intentionally unchanged.lib/core/nip94.ml;descriptor_to_yojson/descriptor_to_jsongain an?include_nip94flag (defaultfalse, preservingSuccess_listshape).Test plan
dune buildpassesdune runtest— 283/283 (newtest_nip94.mlcases +test_http_response.mlcases forSuccess_uploadincludes nip94 + base fields preserved,Success_listexcludes nip94)e2e/test_upload.mltest_upload_response_formatande2e/test_mirror.mltest_mirror_response_formatextended with nip94 assertions — run against a live server (dune exec e2e/main.exe)Generated with Claude Code