feat: enhancing AWS provider GetDNSClusterIP for IPv6 - #563
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 47.02% 47.12% +0.09%
==========================================
Files 40 40
Lines 5961 5976 +15
==========================================
+ Hits 2803 2816 +13
- Misses 2999 3000 +1
- Partials 159 160 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Chun-Che Peng <20843713+ccpeng@users.noreply.github.com>
ccpeng
force-pushed
the
ipv6-dns-cluster-ip
branch
from
July 30, 2026 16:08
067afc7 to
b457f60
Compare
ccpeng
marked this pull request as ready for review
July 30, 2026 16:16
ccpeng
enabled auto-merge (squash)
July 30, 2026 16:16
yuxuanzhu01
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #562
Description
GetDNSClusterIP derives the cluster DNS IP by the standard EKS convention—the 10th address of the service CIDR (network address + 10: IPv4's .10, IPv6's ::a)—but it only reads ServiceIpv4Cidr and computes this via dotted-quad string math (strings.Split(ip, ".")[3]), so on an IPv6 EKS cluster, where ServiceIpv4Cidr is empty and ServiceIpv6Cidr is set instead, it panics with index out of range [3] with length 1 and crashes every InstanceGroup reconcile before any status is written. This makes the derivation IPv6-aware (parse ServiceIpv6Cidr and return the service CIDR's network address with its last byte set to 0x0a) and adds guards so a malformed or empty CIDR returns "" instead of panicking. Verified against a live IPv6 cluster (fd31:8cc0:942b::/108 → fd31:8cc0:942b::a, matching the actual kube-dns ClusterIP) with unit tests covering the IPv6, empty-CIDR, and nil-config cases.
Testing performed
Checklist
make testlocally and all tests passgit commit -sfor DCO verification