fix(swap): honest copy when no route exists for an asset - #398
Merged
Conversation
'{{coin}} swaps are not yet supported via THORChain' was wrong twice: the
swappable-asset list is a union across providers (THORChain, Maya, Relay,
ChainFlip), and the panel fires whenever an asset is absent from that list —
which is 'no route offered right now', not a THORChain protocol limitation.
It read as a permanent capability statement.
Live proof it misleads: THORChain has 41 available pools including GAIA.ATOM,
while pioneer serves 23 assets without it. That is a pioneer coverage gap
(handoff filed), not a THORChain limitation, and the old copy sent users
looking in the wrong place.
Rewrites the string in all 15 locales, adds a hint that routes change over
time, and drops the THORChain provider badge from a panel that is not
provider-specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: 'Cosmos swaps are not yet supported via THORChain — this is incorrect?' Correct, it was wrong twice over.
And it was masking a real gap. Live check today: THORChain has 41 available pools including
GAIA.ATOM,XRP.XRPand the full ERC-20 set; pioneer serves Vault 23 assets with none of those. Pioneer's/quotealso refusesGAIA.ATOM → BTC.BTCwith 'No quotes available', so this cannot be shimmed vault-side the way RUNE/TRON were — filed as a pioneer handoff (docs/handoff-swap-asset-coverage-2026-08-05.md).Change
ProviderBadgefrom this non-provider-specific panelmake test-unit: 343 pass. All locale JSON validated.