Conversation
- enforce the 15s budget on the in-flight fetch (AbortSignal.timeout per attempt) — a hung upstream connection no longer blocks past the budget - CORS: echo only trusted origins (help.keboola.com, *.vercel.app previews, localhost) instead of wildcard — foreign pages can't script the proxy - cap message length (2000 chars) to protect the shared AI quota - return a generic error to the client; log the real one server-side Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Iamfle4ka
added
the
site-tooling
Collaborator
Author
|
@keboola-pr-reviewer review |
keboola-pr-reviewer-bot
left a comment
keboola-pr-reviewer-bot
left a comment
There was a problem hiding this comment.
Verdict: needs_human (risk 4/5) · profile connection-docs
Escalating to a human because this PR modifies the Ask Kai chat proxy (api/chat.ts), which policy lists under "Always needs human — escalate no matter how small." Policy's "Always needs human"…
Suggested reviewers: @keboola/docs
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-cut of #1011 (closed 2026-08-19 under the stale-draft mandate) onto current
main— the gap it fixes is still live:api/chat.tsservesaccess-control-allow-origin: *on a proxy that runs a shared Storage token, so any page on the internet can script it and burn AI quota.What changes:
*— the origin is echoed back only forhelp.keboola.com,*.vercel.apppreviews, andlocalhost; everything else gets no CORS header.vary: originset accordingly.AbortSignal.timeout(remainingBudget)into the upstream fetch, so one hung connection can't blow past the 15s budget.console.error), the client sees a generic message instead of raw error text.Single cherry-pick of the reviewed commit from the kept
fix/chat-proxy-hardeningbranch; applied cleanly,tsc --noEmitpasses. Per the connection-docs bot profile,api/chat.tscorrectly escalates to a human reviewer.🤖 Generated with Claude Code