Skip to content

PRDCT-594: reshoot the flow screenshots that showed retired UI - #1078

Merged
jordanrburger merged 3 commits into
mainfrom
docs/reshoot-legacy-flow-shots
Aug 5, 2026
Merged

jordanrburger merged 3 commits into
mainfrom
docs/reshoot-legacy-flow-shots

Conversation

@Iamfle4ka

Copy link
Copy Markdown
Collaborator

Jira issue(s): PRDCT-359 · related PRDCT-570, PRDCT-478

Jordan's 07-30 item — "some still show versions of flows that no longer exist". It turned out to cover three UI generations, all sitting on pages about the current product:

Page Image What it actually showed
/management/notifications/ orchestration-main-1.png the 2019 Orchestrations UI — nav row with Orchestrations, "RUN ORCHESTRATION", a run row dated 2019-11-07
/management/notifications/ orch-notifications.png the same 2019 Orchestrations notification form
/management/notifications/ flow-notifications.png legacy flow chrome, plus a Warnings card a Conditional Flow does not have
/management/notifications/ webhook-notification.png an in-between generation (Schedules tab already there, Warnings still there)
/transformations/variables/ orchestration-parameters.png the 2019 Orchestrations Tasks table and its "Edit Task parameters" item
/transformations/variables/ task-parameters.png the Legacy Flow Builder task panel
/flows/ task panel + schedule the Legacy builder: Step 1/Step 2, GoodData, and a live Continue on Failure toggle — three paragraphs below prose saying failure handling is expressed through conditions instead of that toggle

Changes:

  • Six fresh retina captures from the [TUTORIAL] Opportunity pipeline flow in demo project 264 (per the 07-10 rule on which project screenshots come from): task settings panel, Task Parameters modal, Schedules tab, Create Schedule dialog, Notifications tab, Webhook sub-tab. Nothing in the project was modified — panels were opened and dismissed, and the flow's one schedule stays disabled.
  • Deleted the two 2019 Orchestrations images; no reference to them survives anywhere.
  • Prose the old screenshots were hiding, corrected against the live UI:
    • Scheduling is the Schedules tab → Create Schedule → Set Up Schedule, not a "Set Schedule" link. A flow can hold several schedules, each with its own toggle, each of type Date & Time or Triggered, and the dialog previews the next runs.
    • The Notifications tab is Success / Errors / Processing and edits in place. There is no Edit Notifications button anywhere in the product (grep now returns nothing repo-wide).
    • The Warnings card belongs to Legacy Flows, where Continue on Failure yields a warning status; the section now says which cards belong to which flow type and links the migration guide, rather than dropping the warning event as if it did not exist.
    • The page's two duplicate "Flow Notifications" sections are merged into one and the remaining types renumbered — no inbound anchor pointed at the old numbers.

Left alone on purpose

  • /flows/flows-legacy/ and /flows/orchestrator/ keep their legacy captures — that is what those pages document. Note that flows-legacy shares /flows/task-parameters.png and /flows/set-schedule.png with the conditional page, so the new conditional shots got their own filenames; both legacy files are byte-identical to main.
  • The June conditional-flows-*.png set: it shows the current builder and has drifted only by the new "Handled via Conditions" row.
  • The 15 legacy captures in /tutorial/automate/ are already reshot on PRDCT-487-getting-started and land with PRDCT-487: Getting Started — rewrite /tutorial/ as the customer-lifecycle arc #1071.

For the reviewer

  • Four claims on the notifications page predate this PR and no public source confirms them — the averaging window for the processing-overtime event, manual-run recipient routing, the dev-branch limitation, and the webhook 5s-timeout/no-retry policy. Flagged inline as VERIFY(owner) rather than silently kept or silently deleted.
  • Pre-existing issues found nearby and not touched here: flows-legacy/index.md:103 inverts the Component Enabled logic ("activate … the task will then be excluded"), and the webhook payload example uses keboola.orchestrator, i.e. a legacy flow, where Conditional Flows are keboola.flow.

Verified: npm run build clean (306 pages) · node scripts/audit-phase2.mjs → 0 missing images, and the same 45 broken internal links as main (checked against a stashed baseline, not assumed) · every touched section eyeballed in a production preview, including the Legacy page to confirm its own captures came back.

Draft: opened for review of the approach before it goes in the queue.

🤖 Generated with Claude Code

Jordan's 07-30 note ("some still show versions of flows that no longer exist")
turned out to cover three UI generations, all on pages about the current product:

- /management/notifications/ carried two screenshots of the **2019 Orchestrations**
  UI — nav row Dashboard/Components/Data Catalog/Storage/Orchestrations, "RUN
  ORCHESTRATION", a run table dated 2019-11-07 — under prose telling readers to
  click an **Edit Notifications** button that does not exist anywhere in the
  product. Both images are deleted; the section now shows the real Notifications
  tab.
- /transformations/variables/ illustrated flow task parameters with the same 2019
  Orchestrations "Tasks" table and its "Edit Task parameters" menu item.
- /flows/ (Conditional Flows) showed the **Legacy** Flow Builder: Step 1/Step 2
  phases, a GoodData destination, and a real "Continue on Failure" toggle — three
  paragraphs below prose stating that failure handling is expressed through
  conditions *instead of* that toggle.

All captures are fresh, retina, from the [TUTORIAL] Opportunity pipeline flow in
demo project 264 (per Jordan's 07-10 rule on which project screenshots come from).
Nothing in the project was changed: panels were opened and dismissed, and the
flow's one schedule stays disabled.

Prose the old screenshots were hiding, corrected against the live UI:

- Scheduling is **Schedules tab > Create Schedule > Set Up Schedule**, not a
  "Set Schedule" link. A flow may hold several schedules, each with its own
  toggle, each of type Date & Time or Triggered, and the dialog previews the next
  runs. /flows/ had described the legacy entry point.
- The Notifications tab has **Success / Errors / Processing** and edits in place.
  There is no Warnings card on a Conditional Flow — that one belongs to Legacy
  Flows, where Continue on Failure produces a warning status, so the section now
  says which is which and links the migration guide.
- The page's two duplicate "Flow Notifications" sections are merged into one and
  the remaining types renumbered (no inbound anchor pointed at the old numbers).

Deliberately left alone: /flows/flows-legacy/ and /flows/orchestrator/ keep their
legacy captures, which is what those pages document — note that flows-legacy
*shares* /flows/task-parameters.png and /flows/set-schedule.png with the
conditional page, so the new conditional shots got their own filenames rather than
overwriting the legacy pair. The June conditional-flows-*.png set stays as is; it
shows the current builder and has only drifted by the new "Handled via Conditions"
row. The 15 legacy captures in /tutorial/automate/ are already reshot on
PRDCT-487-getting-started and land with that branch.

Four claims on the notifications page predate this change and no public source
confirms them (the averaging window, manual-run routing, the dev-branch
limitation, the webhook timeout/retry policy) — flagged inline as VERIFY(owner).

Verified: `npm run build` clean, `audit-phase2.mjs` at 0 missing images and the
same 45 pre-existing broken links as main, and every touched section eyeballed in
a production preview.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

PRDCT-359

PRDCT-594

@vercel

vercel Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
connection-docs Ready Ready Preview Aug 5, 2026 4:37pm

Request Review

@Iamfle4ka
Iamfle4ka marked this pull request as ready for review August 4, 2026 23:33

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 3/5) · profile docs

Needs a human: substantive product-behavior rewrites plus in-place screenshot swaps that the bot can't verify.

Impact flags: possible rollback re-introduction — see Check Run summary.

Concerns:

  • src/content/docs/flows/index.md: Rewritten scheduling prose asserts unverifiable product behaviour (Set Up Schedule flow, UTC, next-run preview).
  • src/content/docs/management/notifications/notifications.md: New notification-card and Warnings/Legacy claims need product-team confirmation.
  • public/management/notifications/flow-notifications.png: Screenshot replaced in place; visual content can't be diffed by the bot.
  • + 1 more concern — see Check Run summary.

Suggested reviewers: @keboola/docs

@Iamfle4ka Iamfle4ka changed the title PRDCT-359: reshoot the flow screenshots that showed retired UI PRDCT-594: reshoot the flow screenshots that showed retired UI Aug 4, 2026
@Iamfle4ka
Iamfle4ka marked this pull request as draft August 4, 2026 23:38
@Iamfle4ka
Iamfle4ka requested a review from jordanrburger August 5, 2026 15:17
@jordanrburger
jordanrburger marked this pull request as ready for review August 5, 2026 16:28

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 3/5) · profile docs

Needs human: in-place screenshot replacements and new product-behaviour prose can't be verified from the diff.

Concerns:

  • public/management/notifications/flow-notifications.png: Screenshots replaced in place — reviewer cannot diff visual content.
  • src/content/docs/management/notifications/notifications.md: Rewritten paragraphs add product-behaviour claims needing product-team confirmation.
  • src/content/docs/management/notifications/notifications.md: Links /flows/#conditions and migration-guide page unverifiable from diff.

Suggested reviewers: @keboola/docs

@jordanrburger
jordanrburger enabled auto-merge August 5, 2026 16:35
@jordanrburger
jordanrburger merged commit 039a7f8 into main Aug 5, 2026
2 of 3 checks passed
@jordanrburger
jordanrburger deleted the docs/reshoot-legacy-flow-shots branch August 5, 2026 16:36

This branch was successfully deployed

1 active deployment
Preview — 24435195 Deployed Aug 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants