Update dependencies and fix tests (part 1)#3734
Open
briehl wants to merge 2 commits into
Open
Conversation
briehl
commented
Jul 24, 2026
| ]; | ||
|
|
||
| /** | ||
| * Stubs the NarrativeMethodStore and Catalog service calls that the app cell makes |
Member
Author
There was a problem hiding this comment.
This is all due to the jasmine-core and jasmine-ajax updates.
briehl
commented
Jul 24, 2026
Comment on lines
-128
to
131
| userId + | ||
| properId + | ||
| '" target="_blank">' + | ||
| properId + | ||
| '</a>)' |
Member
Author
There was a problem hiding this comment.
I'm not entirely sure why this failed before, but it works now.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ |
|
|
||
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ |
| WORKDIR /kb/dev_container/narrative | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | bash - && \ | ||
| apt-get install -y nodejs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
I'm going to break this down into a few PRs to keep them contained
Update many JS dependencies and fix test regressions. Some were related to the dep updates, others not so much.
Some are untouched because they either (a) break everything or (b) have a cascading effect on other dependencies that break everything.
I'd like to bump all of these, and maybe put a coding agent to work on updating our jQuery usage just to get away from jQuery 2, but certainly not in this PR.