438. Find All Anagrams in a String - #114
Open
kazuki-official wants to merge 1 commit into
Open
Conversation
nodchip
reviewed
Jul 2, 2026
| return {}; | ||
| } | ||
| std::unordered_map<char, int> letter_to_count_in_p; | ||
| for (const char& c : p) { |
There was a problem hiding this comment.
こちらのコメントをご参照ください。
hemispherium/LeetCode_Arai60#10 (comment)
Owner
Author
There was a problem hiding this comment.
変数の型サイズが CPU のレジスタ幅以下の場合、値渡しにしたほうが効率的な場合があります。
完全に盲点でした。変数の型サイズも意識するようにします。、
| } | ||
|
|
||
| int num_incorrects = 0; | ||
| for (const auto& [letter, count] : letter_to_count_in_p) { |
There was a problem hiding this comment.
こちらのコメントをご参照ください。
5ky7/arai60#22 (comment)
今回のケースでは、値で受けたほうが良いと思います。
| #include <vector> | ||
| #include <string> | ||
|
|
||
| const int NUM_ALPHABETS(26); |
There was a problem hiding this comment.
定数を定義する際、コンパイル時に値が決まるものについては、 const より constexpr を使ったほうが良いと思います。
https://cpprefjp.github.io/lang/cpp11/constexpr.html
Owner
Author
There was a problem hiding this comment.
今回はconstexprが良さそうですね。ありがとうございます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/find-all-anagrams-in-a-string/description/