11. Container With Most Water - #111
Open
kazuki-official wants to merge 1 commit into
Open
Conversation
nodchip
reviewed
Jul 2, 2026
| * `[3, 6, 1]`などの場合は, 更新のやり方によっては最大の水を捉えられない. | ||
|
|
||
| ```cpp | ||
| #include <vector> |
There was a problem hiding this comment.
include 文を書く際、ファイル名の辞書順で並べるスタイルもあります。
参考までにスタイルガイドへのリンクを共有いたします。
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Within each section the includes should be ordered alphabetically.
なお、このスタイルガイドは“唯一の正解”というわけではなく、数あるガイドラインの一つに過ぎません。チームによって重視される書き方や慣習も異なります。そのため、ご自身の中に基準を持ちつつも、最終的にはチームの一般的な書き方に合わせることをお勧めします。
Owner
Author
There was a problem hiding this comment.
知らなかったです。今後の演習で意識するようにします。
| } | ||
|
|
||
| private: | ||
| void BuildImplementation(int node_i, int left, int right){ |
There was a problem hiding this comment.
{ の前にスペースが空いているものと空いていないものが混ざっているのが気になりました。空けるほうに統一することをお勧めいたします。
| BuildImplementation(1, 0, array_.size() - 1); | ||
| } | ||
|
|
||
| void Update(int array_i, int new_value){ |
There was a problem hiding this comment.
array_index とフルスペルで書いたほうが、読み手にとって読みやすくなると思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/container-with-most-water/description/