ci(release): publish the GitHub release after moving the major tag - #14
Merged
Merged
Conversation
The release workflow built the images and moved v2 but never published a GitHub release, so the repository page still showed v2.0.1, the last one written by hand. The tag job now publishes vX.Y.Z last, with notes generated from the pull requests merged since the previous release, and leaves an existing release alone on a re-run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
release.ymlbuilds the images and movesv2, but never publishes a GitHub release. The repository page still shows v2.0.1 as Latest, the last release written by hand. Since then v2.1.0 through v2.2.1 have shipped.What
tagjob, a new last step:gh release create "$GITHUB_REF_NAME" --verify-tag --generate-notes. The notes list the pull requests merged since the previous release.v2moves, so a published release names a version that is live.gh release view, so re-running a failed release leaves an existing release alone.Test plan
gh release createcall. This checks the command and the generated notes, and leaves v2.2.1 as Latest.