Skip to content

fix: wire up cancel reconnect button#191

Closed
MojtabaMoslemyazdi wants to merge 1 commit into
kasmtech:masterfrom
MojtabaMoslemyazdi:feature/cancel-reconnect-button
Closed

fix: wire up cancel reconnect button#191
MojtabaMoslemyazdi wants to merge 1 commit into
kasmtech:masterfrom
MojtabaMoslemyazdi:feature/cancel-reconnect-button

Conversation

@MojtabaMoslemyazdi

Copy link
Copy Markdown

Summary

The reconnect screen includes a "Cancel" button, but no click handler is registered for it. As a result, clicking the button has no effect.
This change registers the existing UI.cancelReconnect handler for the noVNC_cancel_reconnect_button element, making the button functional.

Changes

  • Add click event listener for noVNC_cancel_reconnect_button
  • Invoke the existing UI.cancelReconnect handler when the button is clicked

Testing

  1. Enable automatic reconnect.
  2. Disconnect the VNC session to trigger the reconnect screen.
  3. Click the Cancel button.
  4. Verify that the reconnect process is cancelled as expected.

@mmcclaskey

Copy link
Copy Markdown
Collaborator

@MojtabaMoslemyazdi, this was taken in a new pull request #195 , as it was related to some other issues that would have all required the same testing. Closing this pull request, thank you much for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants