sonarqube cleanup.

Author: karlnicholas

src/main/java/org/hdf5javalib/hdffile/dataobjects/HdfObjectHeaderPrefix.java

@@ -3,7 +3,6 @@
 import org.hdf5javalib.dataclass.HdfFixedPoint;
 import org.hdf5javalib.hdffile.dataobjects.messages.HdfMessage;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.hdfjava.HdfFileAllocation;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
@@ -58,7 +57,7 @@ public List<HdfMessage> getHeaderMessages() {
         return headerMessages;
     }
 
-    public abstract void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel, HdfFileAllocation fileAllocation) throws IOException;
+    public abstract void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel) throws IOException;
 
     public void writeInitialMessageBlockToBuffer(ByteBuffer buffer) {
     }

src/main/java/org/hdf5javalib/hdffile/dataobjects/HdfObjectHeaderPrefixV1.java

@@ -3,7 +3,6 @@
 import org.hdf5javalib.dataclass.HdfFixedPoint;
 import org.hdf5javalib.hdffile.dataobjects.messages.HdfMessage;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.hdfjava.HdfFileAllocation;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
@@ -62,12 +61,11 @@ public HdfObjectHeaderPrefixV1(int version, long objectReferenceCount, long obje
      * </p>
      *
      * @param seekableByteChannel the byte channel to write to
-     * @param fileAllocation      the file allocation manager
      * @throws IOException           if an I/O error occurs
      * @throws IllegalStateException if the buffer overflows
      */
     @Override
-    public void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel, HdfFileAllocation fileAllocation) throws IOException {
+    public void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel) throws IOException {
         int currentSize = 16;
         int i = 0;
         while (i < headerMessages.size()) {

src/main/java/org/hdf5javalib/hdffile/dataobjects/HdfObjectHeaderPrefixV2.java

@@ -2,7 +2,6 @@
 
 import org.hdf5javalib.hdffile.dataobjects.messages.HdfMessage;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.hdfjava.HdfFileAllocation;
 import org.hdf5javalib.utils.HdfWriteUtils;
 
 import java.io.IOException;
@@ -49,7 +48,7 @@ public HdfObjectHeaderPrefixV2(
         this.minDenseAttributes = minDenseAttributes;
     }
     @Override
-    public void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel, HdfFileAllocation fileAllocation) throws IOException {
+    public void writeAsGroupToByteChannel(SeekableByteChannel seekableByteChannel) throws IOException {
         // not implemented
     }
 }

src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeap.java

@@ -1,9 +1,7 @@
 package org.hdf5javalib.hdffile.infrastructure;
 
 import org.hdf5javalib.dataclass.HdfFixedPoint;
-import org.hdf5javalib.hdfjava.AllocationType;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.hdfjava.HdfFileAllocation;
 import org.hdf5javalib.utils.HdfReadUtils;
 import org.hdf5javalib.utils.HdfWriteUtils;
 
@@ -30,7 +28,6 @@
  *
  * @see HdfDataFile
  * @see HdfFixedPoint
- * @see HdfFileAllocation
  */
 public class HdfGlobalHeap {
     private static final byte[] GLOBAL_HEAP_SIGNATURE = {'G', 'C', 'O', 'L'};
@@ -181,8 +178,6 @@ public void initializeFromSeekableByteChannel(SeekableByteChannel fileChannel, H
                 localCollectionSize,
                 localNextObjectId,
                 hdfDataFile,
-                globalHeaps.size() > 0 ? AllocationType.GLOBAL_HEAP_2 : AllocationType.GLOBAL_HEAP_1,
-                globalHeaps.size() > 0 ? "Global Heap 2" : "Global Heap 1",
                 hdfStartOffset
         );
         globalHeaps.put(hdfStartOffset, heapBlock);

src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeapBlock.java

@@ -1,7 +1,6 @@
 package org.hdf5javalib.hdffile.infrastructure;
 
 import org.hdf5javalib.dataclass.HdfFixedPoint;
-import org.hdf5javalib.hdfjava.AllocationType;
 import org.hdf5javalib.hdfjava.HdfDataFile;
 import org.hdf5javalib.utils.HdfWriteUtils;
 
@@ -21,17 +20,13 @@ public class HdfGlobalHeapBlock {
     /**
      * Constructs an allocation record.
      *
-     * @param type           the allocation type
-     * @param name           the name of the allocation
      * @param offset         the starting offset
      */
     public HdfGlobalHeapBlock(
             LinkedHashMap<Integer, GlobalHeapObject> globalHeapObjects,
             HdfFixedPoint collectionSize,
             Integer nextObjectId,
             HdfDataFile hdfDataFile,
-            AllocationType type,
-            String name,
             HdfFixedPoint offset
     ) {
         this.hdfDataFile = hdfDataFile;

src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfLocalHeap.java

@@ -3,7 +3,6 @@
 import org.hdf5javalib.dataclass.HdfFixedPoint;
 import org.hdf5javalib.dataclass.HdfString;
 import org.hdf5javalib.hdfjava.HdfDataFile;
-import org.hdf5javalib.hdfjava.HdfFileAllocation;
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
@@ -24,7 +23,6 @@
  * @see HdfDataFile
  * @see HdfFixedPoint
  * @see HdfString
- * @see HdfFileAllocation
  */
 public class HdfLocalHeap {
     public static final byte[] LOCAL_HEAP_SIGNATURE = new byte[]{'H', 'E', 'A', 'P'};
@@ -113,10 +111,9 @@ public String toString() {
      * Writes the local heap to a file channel.
      *
      * @param seekableByteChannel the file channel to write to
-     * @param fileAllocation      the file allocation manager
      * @throws IOException if an I/O error occurs
      */
-    public void writeToByteChannel(SeekableByteChannel seekableByteChannel, HdfFileAllocation fileAllocation) throws IOException {
+    public void writeToByteChannel(SeekableByteChannel seekableByteChannel) throws IOException {
         ByteBuffer buffer = ByteBuffer.allocate(LOCAL_HEAP_HEADER_SIZE).order(ByteOrder.LITTLE_ENDIAN);
 
         buffer.put(LOCAL_HEAP_SIGNATURE);

src/main/java/org/hdf5javalib/hdfjava/AllocationRecord.java

@@ -22,13 +22,6 @@ public interface HdfDataFile {
      */
     HdfGlobalHeap getGlobalHeap();
 
-//    /**
-//     * Retrieves the file allocation manager of the HDF5 file.
-//     *
-//     * @return the {@link HdfFileAllocation} instance
-//     */
-//    HdfFileAllocation getFileAllocation();
-
     /**
      * Retrieves the seekable byte channel for reading and writing the HDF5 file.
      *
@@ -45,5 +38,4 @@ public interface HdfDataFile {
 
     HdfBTree getBTree();
 
-    void setFileAllocation(HdfFileAllocation hdfFileAllocation);
 }