sonarqube cleanup.

karlnicholas · karlnicholas · commit 40597ffee0af · 2025-07-29T17:00:58.000-04:00
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfCompound.java b/src/main/java/org/hdf5javalib/dataclass/HdfCompound.java
@@ -80,14 +80,8 @@ public HdfCompound(byte[] bytes, CompoundDatatype datatype) {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfCompoundMember.java b/src/main/java/org/hdf5javalib/dataclass/HdfCompoundMember.java
@@ -68,14 +68,8 @@ public HdfCompoundMember(byte[] bytes, CompoundMemberDatatype datatype) {
     public String toString() {
         try {
             return datatype.getInstance(HdfData.class, bytes).toString();
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfEnum.java b/src/main/java/org/hdf5javalib/dataclass/HdfEnum.java
@@ -83,14 +83,8 @@ public byte[] getBytes() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfFixedPoint.java b/src/main/java/org/hdf5javalib/dataclass/HdfFixedPoint.java
@@ -149,14 +149,8 @@ public boolean isUndefined() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfFloatPoint.java b/src/main/java/org/hdf5javalib/dataclass/HdfFloatPoint.java
@@ -64,14 +64,8 @@ public HdfFloatPoint(byte[] bytes, FloatingPointDatatype datatype) {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfOpaque.java b/src/main/java/org/hdf5javalib/dataclass/HdfOpaque.java
@@ -80,14 +80,8 @@ public byte[] getBytes() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfReference.java b/src/main/java/org/hdf5javalib/dataclass/HdfReference.java
@@ -34,14 +34,8 @@ public ReferenceDatatype getDatatype() {
     public String toString() {
         try {
             return datatype.toString(bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfString.java b/src/main/java/org/hdf5javalib/dataclass/HdfString.java
@@ -105,14 +105,8 @@ public byte[] getBytes() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfTime.java b/src/main/java/org/hdf5javalib/dataclass/HdfTime.java
@@ -94,14 +94,8 @@ public byte[] getBytes() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/dataclass/HdfVariableLength.java b/src/main/java/org/hdf5javalib/dataclass/HdfVariableLength.java
@@ -82,14 +82,8 @@ public byte[] getBytes() {
     public String toString() {
         try {
             return datatype.getInstance(String.class, bytes);
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/datasource/TypedDataSource.java b/src/main/java/org/hdf5javalib/datasource/TypedDataSource.java
@@ -413,14 +413,8 @@ public boolean tryAdvance(Consumer<? super R> action) {
                 action.accept(record);
                 currentIndex++;
                 return true;
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            } catch (InvocationTargetException e) {
-                throw new RuntimeException(e);
-            } catch (InstantiationException e) {
-                throw new RuntimeException(e);
-            } catch (IllegalAccessException e) {
-                throw new RuntimeException(e);
+            } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+                throw new IllegalStateException(e);
             }
         }
 
diff --git a/src/main/java/org/hdf5javalib/examples/HDF5Examples/ExampleDebug.java b/src/main/java/org/hdf5javalib/examples/HDF5Examples/ExampleDebug.java
@@ -43,15 +43,12 @@ private void run() {
             try (SeekableByteChannel channel = Files.newByteChannel(filePath, StandardOpenOption.READ)) {
                 HdfFileReader reader = new HdfFileReader(channel).readFile();
                 log.debug("Superblock: {} ", reader.getSuperblock());
-//    //                try (HdfDataset dataSet = reader.getRootGroup().getDataset("/DS1").orElseThrow()) {
-//                    displayData(channel, dataSet, reader);
-//                }
                 for (HdfDataset dataSet : reader.getDatasets()) {
                     displayData(channel, dataSet, reader);
                 }
             }
         } catch (Exception e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 }
diff --git a/src/main/java/org/hdf5javalib/examples/HDF5Examples/ExamplesRead.java b/src/main/java/org/hdf5javalib/examples/HDF5Examples/ExamplesRead.java
@@ -46,7 +46,7 @@ private void run() {
                         displayFile(p);
                     });
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/h5ex_d/h5ex_d_read.java b/src/main/java/org/hdf5javalib/examples/h5ex_d/h5ex_d_read.java
@@ -47,7 +47,7 @@ private void run() {
 
             }
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/h5ex_t/att/h5ex_t_att_read.java b/src/main/java/org/hdf5javalib/examples/h5ex_t/att/h5ex_t_att_read.java
@@ -47,7 +47,7 @@ private void run() {
 
             }
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/h5ex_t/h5ex_t_read.java b/src/main/java/org/hdf5javalib/examples/h5ex_t/h5ex_t_read.java
@@ -47,7 +47,7 @@ private void run() {
 
             }
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/h5ex_tutr/att/h5ex_tutr_att_read.java b/src/main/java/org/hdf5javalib/examples/h5ex_tutr/att/h5ex_tutr_att_read.java
@@ -47,7 +47,7 @@ private void run() {
 
             }
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/h5ex_tutr/h5ex_tutr_read.java b/src/main/java/org/hdf5javalib/examples/h5ex_tutr/h5ex_tutr_read.java
@@ -47,7 +47,7 @@ private void run() {
 
             }
         } catch (URISyntaxException | IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/read/CompoundRead.java b/src/main/java/org/hdf5javalib/examples/read/CompoundRead.java
@@ -52,7 +52,7 @@ private void run() {
                 }
 
         } catch (Exception e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/read/DimensionsRead.java b/src/main/java/org/hdf5javalib/examples/read/DimensionsRead.java
@@ -64,7 +64,7 @@ private void run() {
                 }
             }
         } catch (Exception e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/examples/read/FixedPointRead.java b/src/main/java/org/hdf5javalib/examples/read/FixedPointRead.java
@@ -73,7 +73,7 @@ void run() throws Exception {
                 tryScalarDataSpliterator(channel, reader, reader.getDatasets().get(0));
             }
         } catch (IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
 
         try {
@@ -83,7 +83,7 @@ void run() throws Exception {
                 tryMatrixSpliterator(channel, reader, reader.getDataset("/weatherdata").orElseThrow());
             }
         } catch (IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
 
         try {
@@ -93,7 +93,7 @@ void run() throws Exception {
                 display4DData(channel, reader, reader.getDataset("/game").orElseThrow());
             }
         } catch (IOException e) {
-            throw new RuntimeException(e);
+            throw new IllegalStateException(e);
         }
     }
 
diff --git a/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/AttributeInfoMessage.java b/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/AttributeInfoMessage.java
@@ -192,14 +192,8 @@ public String toString() {
                     ", attributeNameV2BtreeAddress=" + attributeNameV2BtreeAddress.getInstance(Long.class) +
                     ", attributeCreationOrderV2BtreeAddress=" + (attributeCreationOrderV2BtreeAddress != null ? attributeCreationOrderV2BtreeAddress.getInstance(Long.class) : "N/A") +
                     '}';
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 }
diff --git a/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/DataLayoutMessage.java b/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/DataLayoutMessage.java
@@ -166,7 +166,7 @@ public static HdfMessage parseHeaderMessage(int flags, byte[] data, HdfDataFile
                         bTree = null;
                     }
                 } catch (Exception e) {
-                    throw new RuntimeException(e);
+                    throw new IllegalStateException(e);
                 }
                 dataLayoutStorage = new ChunkedStorage(chunkedDataAddress, dimensionSizes, datasetElementSize, bTree, hdfDataFile);
                 break;
diff --git a/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/LinkInfoMessage.java b/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/LinkInfoMessage.java
@@ -188,14 +188,8 @@ public String toString() {
                     ", v2BTreeNameIndexAddress=" + v2BTreeNameIndexAddress.getInstance(Long.class) +
                     ", v2BTreeCreationOrderIndexAddress=" + (v2BTreeCreationOrderIndexAddress != null ? v2BTreeCreationOrderIndexAddress.getInstance(Long.class) : "N/A") +
                     '}';
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 }
diff --git a/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/SymbolTableMessage.java b/src/main/java/org/hdf5javalib/hdffile/dataobjects/messages/SymbolTableMessage.java
@@ -100,14 +100,8 @@ public String toString() {
                     "bTreeAddress=" + bTreeAddress.getInstance(Long.class) +
                     ", localHeapAddress=" + localHeapAddress.getInstance(Long.class) +
                     '}';
-        } catch (InvocationTargetException e) {
-            throw new RuntimeException(e);
-        } catch (InstantiationException e) {
-            throw new RuntimeException(e);
-        } catch (IllegalAccessException e) {
-            throw new RuntimeException(e);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
+        } catch (InvocationTargetException | InstantiationException | IllegalAccessException | IOException e) {
+            throw new IllegalStateException(e);
         }
     }
 }
diff --git a/src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeap.java b/src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeap.java
@@ -161,10 +161,10 @@ public void initializeFromSeekableByteChannel(SeekableByteChannel fileChannel, H
                         break;
                     }
                     if (localObjects.containsKey(obj.getHeapObjectIndex())) {
-                        throw new RuntimeException("Duplicate object ID " + obj.getHeapObjectIndex() + " found in heap at offset: " + startOffset);
+                        throw new IllegalStateException("Duplicate object ID " + obj.getHeapObjectIndex() + " found in heap at offset: " + startOffset);
                     }
                     if (obj.getHeapObjectIndex() < 1 || obj.getHeapObjectIndex() > 0xFFFF) {
-                        throw new RuntimeException("Invalid object ID " + obj.getHeapObjectIndex() + " found in heap at offset: " + startOffset);
+                        throw new IllegalStateException("Invalid object ID " + obj.getHeapObjectIndex() + " found in heap at offset: " + startOffset);
                     }
                     localObjects.put(obj.getHeapObjectIndex(), obj);
                     localNextObjectId = Math.max(localNextObjectId, obj.getHeapObjectIndex() + 1);
diff --git a/src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeapBlock.java b/src/main/java/org/hdf5javalib/hdffile/infrastructure/HdfGlobalHeapBlock.java
diff --git a/src/main/java/org/hdf5javalib/utils/CsvReader.java b/src/main/java/org/hdf5javalib/utils/CsvReader.java
diff --git a/src/main/java/org/hdf5javalib/utils/HdfWriteUtils.java b/src/main/java/org/hdf5javalib/utils/HdfWriteUtils.java
