fix: recorder widget doesn't hide when not in use (#100) - #106
Merged
Conversation
The recorder redesign made the pill always-present: showIdleRecorder() showed it at launch and returnToIdle() deliberately kept it on screen, so it never went away in either recording mode. Restore hide-when-idle as the default and gate always-visible behind a new "Always show recorder pill" setting (default off): - returnToIdle() now orderOut()s the panel when the toggle is off (hit after commit and after cancel/no-speech). Recording still shows the HUD normally. - showIdleRecorder() only fronts the pill at launch when the toggle is on. - Toggling the setting posts .recorderIdleVisibilityChanged; AppDelegate observes it and calls applyIdleVisibilityPreference() to show/hide live (guards against hiding mid-session via the panel's interactive state). Fixes #100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
Cause
The recorder redesign turned the pill into an always-present widget:
showIdleRecorder()shows it at launch andreturnToIdle()deliberately keeps it on screen. So it never disappears in either recording mode — as multiple users reported.Fix
Restore hide-when-idle as the default, and gate the always-visible behavior behind a new opt-in setting.
returnToIdle()noworderOut()s the panel when the toggle is off (runs after commit and after cancel / no-speech). Recording still shows the HUD viastartRecording().showIdleRecorder()only fronts the pill at launch when the toggle is on..recorderIdleVisibilityChanged;AppDelegateobserves it and callsapplyIdleVisibilityPreference()to show/hide immediately (guards against hiding mid-session via the panel's interactive state).Notes
.glassEffectSDK issue, unrelated to this change.Test plan