Version Packages#224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@mtg-deckbuilder/electron-app@0.12.5
Patch Changes
scryfall-searchskill (cause and mitigation), with a pointer frommtg-deckbuilder-lookupnearget_collection_filter, the most common source of longOR-chains that hit it.archiver8.0.0 bump dropped itsdefaultexport.zipDirectorynow imports theZipArchiveclass and constructs it directly (new ZipArchive({ zlib: { level: 9 } })) instead of calling the removedarchiver('zip', options)factory function.useBuyListscannedgetMainboard(deck), so cards flaggedneed_to_buyin thealternatesorsideboardsets — where this ownership tag is actually used most often — never appeared. It now scansgetNonCutEntries(deck)(mainboard + sideboard + alternates, excluding the cut pile), matching the scopeDeckStatsalready uses for its own "cards needing purchase" count.validateCardLimitsflagging legal decks as invalid because it counted copies acrossalternates(a consideration list, not part of the deck under format rules) alongside mainboard and sideboard. It also missed a card that appears both as a commander and in the mainboard, which should trip the singleton limit but previously didn't since commanders live outsidecardSets. The check is now scoped to mainboard + sideboard + commanders.get_collection_filterbakedr:common OR r:uncommon...into the generated Scryfall query per set, and the pull list view (deck_pull_list) silently dropped any owned-set printing whose rarity exceeded the tracked level — both presented an educated guess about how deeply a user has engaged with a set as certainty about which specific cards they own.get_collection_filternow scopes queries by set only (also keeping generated queries well under Scryfall's 500-character limit), while still returning each set's level/rarities as metadata; the pull list now includes higher-rarity printings from owned sets, flagged as lower-confidence rather than excluded.electron-builder26.15.3 bump. With no explicitexecutableNameset, electron-builder derives the packaged binary's name frompackage.json'snamefield on Linux (appInfo.sanitizedName) rather thanproductName— and unlike the siblinglinuxPackageNamegetter, that path has no guard for scoped package names, so@mtg-deckbuilder/electron-appsanitized down to@mtg-deckbuilderelectron-app, an@-prefixed name electron-builder now rejects as an unsafe file path.executableNameis now set explicitly tomtg-deckbuilderin thebuildconfig, so packaging no longer depends on that derivation.@mtg-deckbuilder/mcp-server@0.12.5
Patch Changes
scryfall-searchskill (cause and mitigation), with a pointer frommtg-deckbuilder-lookupnearget_collection_filter, the most common source of longOR-chains that hit it.archiver8.0.0 bump dropped itsdefaultexport.zipDirectorynow imports theZipArchiveclass and constructs it directly (new ZipArchive({ zlib: { level: 9 } })) instead of calling the removedarchiver('zip', options)factory function.useBuyListscannedgetMainboard(deck), so cards flaggedneed_to_buyin thealternatesorsideboardsets — where this ownership tag is actually used most often — never appeared. It now scansgetNonCutEntries(deck)(mainboard + sideboard + alternates, excluding the cut pile), matching the scopeDeckStatsalready uses for its own "cards needing purchase" count.validateCardLimitsflagging legal decks as invalid because it counted copies acrossalternates(a consideration list, not part of the deck under format rules) alongside mainboard and sideboard. It also missed a card that appears both as a commander and in the mainboard, which should trip the singleton limit but previously didn't since commanders live outsidecardSets. The check is now scoped to mainboard + sideboard + commanders.get_collection_filterbakedr:common OR r:uncommon...into the generated Scryfall query per set, and the pull list view (deck_pull_list) silently dropped any owned-set printing whose rarity exceeded the tracked level — both presented an educated guess about how deeply a user has engaged with a set as certainty about which specific cards they own.get_collection_filternow scopes queries by set only (also keeping generated queries well under Scryfall's 500-character limit), while still returning each set's level/rarities as metadata; the pull list now includes higher-rarity printings from owned sets, flagged as lower-confidence rather than excluded.electron-builder26.15.3 bump. With no explicitexecutableNameset, electron-builder derives the packaged binary's name frompackage.json'snamefield on Linux (appInfo.sanitizedName) rather thanproductName— and unlike the siblinglinuxPackageNamegetter, that path has no guard for scoped package names, so@mtg-deckbuilder/electron-appsanitized down to@mtg-deckbuilderelectron-app, an@-prefixed name electron-builder now rejects as an unsafe file path.executableNameis now set explicitly tomtg-deckbuilderin thebuildconfig, so packaging no longer depends on that derivation.@mtg-deckbuilder/shared@0.12.5
Patch Changes
scryfall-searchskill (cause and mitigation), with a pointer frommtg-deckbuilder-lookupnearget_collection_filter, the most common source of longOR-chains that hit it.archiver8.0.0 bump dropped itsdefaultexport.zipDirectorynow imports theZipArchiveclass and constructs it directly (new ZipArchive({ zlib: { level: 9 } })) instead of calling the removedarchiver('zip', options)factory function.useBuyListscannedgetMainboard(deck), so cards flaggedneed_to_buyin thealternatesorsideboardsets — where this ownership tag is actually used most often — never appeared. It now scansgetNonCutEntries(deck)(mainboard + sideboard + alternates, excluding the cut pile), matching the scopeDeckStatsalready uses for its own "cards needing purchase" count.validateCardLimitsflagging legal decks as invalid because it counted copies acrossalternates(a consideration list, not part of the deck under format rules) alongside mainboard and sideboard. It also missed a card that appears both as a commander and in the mainboard, which should trip the singleton limit but previously didn't since commanders live outsidecardSets. The check is now scoped to mainboard + sideboard + commanders.get_collection_filterbakedr:common OR r:uncommon...into the generated Scryfall query per set, and the pull list view (deck_pull_list) silently dropped any owned-set printing whose rarity exceeded the tracked level — both presented an educated guess about how deeply a user has engaged with a set as certainty about which specific cards they own.get_collection_filternow scopes queries by set only (also keeping generated queries well under Scryfall's 500-character limit), while still returning each set's level/rarities as metadata; the pull list now includes higher-rarity printings from owned sets, flagged as lower-confidence rather than excluded.electron-builder26.15.3 bump. With no explicitexecutableNameset, electron-builder derives the packaged binary's name frompackage.json'snamefield on Linux (appInfo.sanitizedName) rather thanproductName— and unlike the siblinglinuxPackageNamegetter, that path has no guard for scoped package names, so@mtg-deckbuilder/electron-appsanitized down to@mtg-deckbuilderelectron-app, an@-prefixed name electron-builder now rejects as an unsafe file path.executableNameis now set explicitly tomtg-deckbuilderin thebuildconfig, so packaging no longer depends on that derivation.