Skip to content

feat: add license linting#443

Closed
abhinav-1305 wants to merge 11 commits intokagent-dev:mainfrom
abhinav-1305:feature/add-license-lint
Closed

feat: add license linting#443
abhinav-1305 wants to merge 11 commits intokagent-dev:mainfrom
abhinav-1305:feature/add-license-lint

Conversation

@abhinav-1305
Copy link
Copy Markdown
Contributor

@abhinav-1305 abhinav-1305 commented May 27, 2025

fixes: #372, cc: @EItanya.

Comment thread Makefile Outdated
@abhinav-1305 abhinav-1305 requested a review from EItanya May 30, 2025 14:48
@abhinav-1305 abhinav-1305 requested a review from peterj as a code owner May 30, 2025 14:58
@abhinav-1305
Copy link
Copy Markdown
Contributor Author

Hi @EItanya – could you please review this and let me know if any additional licenses need to be added or removed?

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented Jun 9, 2025

Hi @EItanya – could you please review this and let me know if any additional licenses need to be added or removed?

Will look today!

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented Jun 9, 2025

I think for now let's:

  1. remove python license linting and separate into a different later PR if we decide we need it. I don't know about the correct way to do that yet
  2. Update the SHA of the istio tool to be a valid release and test again

@abhinav-1305
Copy link
Copy Markdown
Contributor Author

I think for now let's:

  1. remove python license linting and separate into a different later PR if we decide we need it. I don't know about the correct way to do that yet
  2. Update the SHA of the istio tool to be a valid release and test again

I’ve refactored a few things and updated the SHA for the Istio tool to 1.26.1. Could we possibly re-trigger the actions?

@abhinav-1305
Copy link
Copy Markdown
Contributor Author

Hi @EItanya - GitHub CI failed because v1.26.1 isn’t available for istio/tools/cmd/license-lint. Should we switch to @latest or a commit SHA? Thanks!

@abhinav-1305
Copy link
Copy Markdown
Contributor Author

Ah, can you look into why this is failing, @EItanya?

@abhinav-1305
Copy link
Copy Markdown
Contributor Author

Hi @EItanya - probably lets get this merged in after fixing the CI?

@EItanya
Copy link
Copy Markdown
Contributor

EItanya commented Feb 2, 2026

Stale for 6 months

@EItanya EItanya closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add license-lint

3 participants