Skip to content

fix(ui): tool selection checkboxes snap back to unchecked on click #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjorourke wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(ui): tool selection checkboxes snap back to unchecked on click #1693

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9460de
fix(ui): tool selection checkboxes snap back to unchecked on click
tjorourke Apr 18, 2026
feb277c
Use serverNamesMatch helper instead of ad-hoc normalization
tjorourke Apr 18, 2026
71a3a8f
Merge branch 'main' into fix/tool-selection-checkbox-snaps-back
EItanya Apr 29, 2026
e4df7a3
Merge branch 'main' into fix/tool-selection-checkbox-snaps-back
EItanya Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ui/src/components/onboarding/steps/ToolSelectionStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Alert, AlertDescription, AlertTitle } from "@/components/ui/alert";
import { Info, ChevronDown, ChevronRight, FunctionSquare, Search } from 'lucide-react';
import { LoadingState } from "@/components/LoadingState";
import { ErrorState } from "@/components/ErrorState";
import { getToolResponseDisplayName, getToolResponseDescription, getToolResponseIdentifier, getToolResponseCategory, toolResponseToAgentTool } from "@/lib/toolUtils";
import { getToolResponseDisplayName, getToolResponseDescription, getToolResponseIdentifier, getToolResponseCategory, toolResponseToAgentTool, serverNamesMatch } from "@/lib/toolUtils";
import type { Tool, ToolsResponse } from "@/types";
import { Input } from "@/components/ui/input";

Expand Down Expand Up @@ -39,7 +39,11 @@ export function ToolSelectionStep({
if (tool.type === "Agent" && tool.agent) {
return false; // Agents don't match ToolResponse objects
} else if (tool.type === "McpServer" && tool.mcpServer) {
return tool.mcpServer.name === toolResponse.server_name &&
// toolResponseToAgentTool stores only the name part of a k8s ref in
// mcpServer.name, so normalize both sides via serverNamesMatch to avoid
// "kagent-tool-server" vs "kagent/kagent-tool-server" mismatches that
// cause the controlled <Checkbox> to snap back to unchecked on every click.
return serverNamesMatch(tool.mcpServer.name, toolResponse.server_name ?? "") &&
tool.mcpServer.toolNames.includes(toolResponse.id);
}
return false;
Expand Down