Repository navigation
Fix mapped volume-root backups on Windows - #83
Merged
Merged
Conversation
PrefixFS maps Windows volume roots inside the backup directory. Create that mapping before copying drive-root files, without changing root permissions, ownership, or timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyDircreates mapped root directories withMkdirAll, while still skipping root permission, ownership, and timestamp updates.TestCopyRootDirectoryCreatesMappingWithoutChangingMetadataand record the invariant inSPEC.md.Cause
PrefixFSmaps Windows drive roots to directories inside its prefix. The previous root-directory early return skipped creating that mapped directory. Backing up a drive-root file such asD:\config.envtherefore failed because its snapshot parent did not exist. Ensuring the directory exists fixes this without changing real OS-root metadata.Verification
go vet ./...passed.golangci-lint run: 0 issues.Scope: only
fs_utils.go,fs_utils_test.go, and the spec bug/invariant record; no dependencies, public APIs, or workflow changes.