Skip to content

Not for merging: board check of drmkit's cursor fix - #28

Closed
jwinarske wants to merge 15 commits into
mainfrom
tmp-vf2-cursor-check
Closed

jwinarske wants to merge 15 commits into
mainfrom
tmp-vf2-cursor-check

Conversation

@jwinarske

Copy link
Copy Markdown
Owner

Builds a riscv64 kit against jwinarske/drmkit#134 for the VisionFive 2. To be closed, not merged.

…own card's

- a VisionFive 2's display controller is a card apart from its GPU, and
  importing the renderer's dma-buf into it is refused: "importing a
  buffer: Function not implemented". No frame was shown
- fl-raster's scanout tries the renderer's own ring first, as before,
  and where that is refused asks emblema for one whose buffers GBM
  allocates on the display's card, which the renderer imports and draws
  into (DrmScanoutTarget::with_gbm). Both refusals are said if neither
  works
- the display says which card is its own (ScanoutOutput::device_fd)
- emblema-present-drm's `gbm` feature, through drmkit-gbm: libgbm is
  opened at run time when that ring is asked for, not linked, so a
  board without it runs as before
- review: the card's descriptor is duplicated for the ring and closed
  with it; a ring is rebuilt after a terminal switch on the card's new
  descriptor. One crate more in the kms build, drmkit-gbm, pure Rust

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- run-app --kms --mode WxH[@hz]: one of the display's own modes of that
  size, at the rate nearest the one said or its fastest. A display's
  preferred mode can be more than a board draws at: a VisionFive 2 on a
  3840x2160 monitor showed a frame in three blanks
- a size the display has not is an error that lists the sizes it has
- the mode asked for is kept for the card opened again after a switch
  of terminals
- board kit: run.sh --mode passes it to the display's and the devices'
  checks
- review: the size and rate are parsed as numbers and matched against
  the kernel's list, never set as timings of their own

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
…p and 60 Hz

- docs/m4-status.md: the second board. Its display controller takes no
  buffer of the renderer's, so the ring is GBM's; its monitor's own
  mode, 3840x2160, is more than it draws at; at 1280x720 and 60 Hz no
  blank is missed once the CPU's governor is `performance`, and one
  frame in twelve takes two under the image's `ondemand`
- docs/m1-exit.md: both boards have run the kit with 0 failed, which
  closes exit criterion 2, the last one open. The VisionFive 2's report
  is there
- docs/m4-exit.md, README, CHANGELOG: the board as run. Its devices are
  what is left: nothing was plugged in
- board kit: a negative RSS growth reads -128 kB, not +-128
- review: documents, and one line of a shell script checked under dash

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
The changelog's two lists of milestone 4 are one: main's line names
emblema 0.3.0, and this branch's two lines follow it.

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- docs/m4-status.md: ticker's animation seen by a person, its colors
  as they should be
- review: one line of a document

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
…t, for a board check

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- Ctrl+Alt+F2 and back under an app that draws only when something
  changes left the console on the screen: seen on the VisionFive 2 with
  the cursors app. Nothing drew, so nothing took the card again
- the seat tells who asked when the session comes back
  (Seat::on_resume), and the raster thread draws its last scene again
  (RasterThread::redrawer); a target that cannot lose its frame keeps no
  scene for it
- the display knows the card went and came back with nobody looking,
  by the session's count of its comings back, where it knew only a
  switch it had looked during
- --capture asks for the planes on its own descriptor: after a switch
  it could read the card before the display had taken it again, and
  saw no plane
- on the Pi 5: cursors, a switch away and back by synthetic keys, the
  display read back before and after: the same frame
- review: the callback runs on the seat's thread and only sends on a
  channel, so it cannot wait on the seat; a redraw that fails, the card
  not yet back, is not the run's failure. One scene is kept, and only
  for a display

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- a run with --kms and --frames printed its totals and never exited:
  seen on the VisionFive 2 with counter. The seat kept the redrawer it
  was given for a session's coming back, the redrawer kept a sender,
  and the raster thread ended only when every sender was gone
- finish sends the thread its end, after what is queued; an uploader or
  a redrawer that outlives it sends to nobody
- on the Pi 5: ticker --kms --frames 60 exits 0
- review: scenes queued before the end are still drawn, in order; the
  one sender that counted scenes is the owner's, which sends nothing
  after it

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
…ard check

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
… devices

- a VisionFive 2's display controller shows a cursor newly set as
  noise until it is next moved, its buffer right all the while: a mouse
  nudged once and left kept the noise. A cursor just shown, or given a
  new shape, is told to the card twice more, a tick apart, with nothing
  new to tell
- docs/m4-status.md: the board's devices, with a person at it: keys,
  the mouse and its wheel, all 35 cursors, a capture, a switch of
  terminals, counter; and its cursor's two faults, the one near the
  edges fixed in drmkit (drmkit#134), not yet in a release pinned here
- docs/m4-exit.md, README: the board's input as tried
- review: two more cursor calls after a show or a shape, then none; a
  mouse that keeps moving makes none extra

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- docs/m4-status.md, docs/m4-exit.md: pointer's cursor is clean from
  its first nudge; counter's is still noise when it first appears,
  which stays open. The button's arrow is what the framework asks for
- review: documents

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
- telling a VisionFive 2's display controller a newly shown cursor
  again at the same place did nothing for it: under counter, where the
  board's slow frames leave a nudge of the mouse as one move, the noise
  stayed until the mouse moved on. The first of the two settling ticks
  is now a pixel to the right, the second where the cursor is
- review: one pixel for one tick, about 16 ms, after a cursor appears
  or changes shape; a mouse that keeps moving sees none of it

Signed-off-by: Joel Winarske <joel.winarske@linux.com>
Signed-off-by: Joel Winarske <joel.winarske@linux.com>
@jwinarske

Copy link
Copy Markdown
Owner Author

The board check is done. The edge fix it carried is in drmkit 0.1.6 (jwinarske/drmkit#134); the change for the cursor's first appearance did not work and is recorded as #29.

@jwinarske jwinarske closed this Nov 17, 2026
@jwinarske
jwinarske deleted the tmp-vf2-cursor-check branch November 17, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant