Repository navigation
The test that runs fl-dart in another directory reruns after a qemu crash too - #26
Merged
Merged
Conversation
…rash too - program_named_relative_to_the_working_directory built its own command, so it had none of the harness's one rerun when qemu-user crashes in its own code. The riscv64 cross lane failed on main at 7bf45e6 with that crash ("QEMU internal SIGSEGV {code=MAPERR, addr=0x20}", the signature the harness names), and with it no board kit was made - common::fl_dart_in runs fl-dart in a directory with the same rerun; fl_dart is it with none - review: test harness only. A fault in fl-dart is a guest signal and never carries the emulator's text, and a second crash still fails Signed-off-by: Joel Winarske <joel.winarske@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The riscv64 cross lane failed on main at the #24 merge:
That is the emulator crashing in its own code, the case
common::fl_dartreruns once for. This test built its own command to set a working directory, so it had no rerun.common::fl_dart_in(dir, args):fl_dartin a directory, with the same single rerunTest harness only. The failed job is re-running on main meanwhile.