Repository navigation
Read ten-bit scanout formats back in a capture - #132
Merged
Merged
Conversation
snapshot reads XRGB2101010, ARGB2101010, XBGR2101010 and ABGR2101010, each at eight bits a channel: the low two bits of a ten-bit channel are dropped, and two bits of alpha widen by replication. A Vulkan client's scanout buffer is often one of these. On a Raspberry Pi 5 the primary plane of such a client was skipped as an unsupported format, and a capture showed the cursor plane on nothing. Seen on the Pi 5 through a client that holds the card: the primary plane and the cursor in one PNG. Review: one more arm in a pixel reader whose chunk is four bytes by the format's own size, so no new indexing; the alpha variants go through the same clamp to alpha as ARGB8888. No new dependency, nothing on a hot path. Signed-off-by: Joel Winarske <joel.winarske@linux.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drmkit_capture::snapshotskipped a plane inXRGB2101010, which is what a Vulkan client on a Raspberry Pi 5 scans out. A capture of such a client was the cursor on a transparent image.It now reads
XRGB2101010,ARGB2101010,XBGR2101010andABGR2101010, at eight bits a channel.The README's host test count goes up by one at the next release.