Skip to content

ci: add knip script - #147

Open
jvxz wants to merge 5 commits into
mainfrom
ci/knip
Open

ci: add knip script#147
jvxz wants to merge 5 commits into
mainfrom
ci/knip

Conversation

@jvxz

@jvxz jvxz commented Jul 23, 2026

Copy link
Copy Markdown
Owner

No description provided.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
magi 047d74b Jul 23 2026, 12:43 AM

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR wires up knip (dead code / unused exports detector) into both the npm scripts and the CI pipeline. The knip devDependency and a knip:fix script were already present; this change adds the plain knip script and a matching CI step.

  • Adds "knip": "knip" to package.json scripts, completing the knip / knip:fix script pair that already existed.
  • Inserts a knip CI step between lint and fmt:check, keeping the check order logical and ensuring dead-code issues fail the build.

Confidence Score: 5/5

Safe to merge — the change is additive and self-contained, with no risk of breaking existing behaviour.

Both files touch only CI configuration and script registration. The knip binary is already installed as a devDependency, a config file (knip.ts) is already present, and the CI step follows the same pattern as every other check step in the workflow.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Adds a knip step between lint and format-check; the step runs pnpm knip and fits naturally in the existing check sequence.
package.json Adds the missing "knip": "knip" script; knip:fix already existed and knip is already a devDependency, so the addition is complete and correct.

Reviews (1): Last reviewed commit: "ci: separate knip from ci to its own wor..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant