Repository navigation
Conversation
After a tap, the browser sends a compatibility mousedown once the touch ends. When the tap opened the dialog (a binary message marker on the map), that mousedown lands on the new scrim and closes it within a few milliseconds, so on phones the dialog only flashes. pointerdown for the tap fires before the dialog opens; with a mouse it behaves like mousedown, so a text selection ending on the scrim still does not dismiss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R4CXVA4bmJ9LCW5Ud7FsZJ
jvde-github
added a commit
that referenced
this pull request
Oct 9, 2026
…he scrim dismisses on a click that began on it, so the mouse events that follow a tap cannot close it, and nothing under the scrim is pressed (reported in #661)
Owner
|
Thanks, the cause is exactly as you describe. With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On phones and tablets, tapping a binary message marker on the map (meteo, AtoN, area…) flashes the message dialog, which closes again at once. Ships work because they open the side card, not the modal.
Cause
The modal dismisses on
mousedownon its scrim (frontend/packages/ui/components.js). After a tap, the browser sends compatibility mouse events once the touch ends. The tap itself opened the dialog, so themousedownthat follows lands on the new scrim and closes it.I reproduced it in Chrome with touch emulation. A MutationObserver on
#binary-messagesshowed the sequence:Fix
Dismiss on
pointerdowninstead ofmousedown. The tap'spointerdownfires before the dialog exists, so it can't close it. With a mouse,pointerdownfires at the same moment asmousedown, so desktop behaviour doesn't change, and a text selection that ends on the scrim still doesn't dismiss. The comment says why it's notmousedown.Tested on the viewer with touch emulation and with a mouse. The dialog stays open on tap, and clicking the scrim still closes it with a mouse. The modal is shared with the hub, so the hub's mobile view may be affected too, but I couldn't check that from here.
Source/Web/WebDB.cppis left un-baked for you to regenerate.Found while testing #660 on station 3966 (VA2PXR), live at https://ais-catcher.rplnet.ca.
🤖 Generated with Claude Code
https://claude.ai/code/session_01R4CXVA4bmJ9LCW5Ud7FsZJ