Skip to content

fix: restore window scrolling on main grid, optimize scroll-to-top, and enhance a11y & link security - #69

Open
zarifnexus wants to merge 1 commit into
juxtopposed:mainfrom
zarifnexus:fix/grid-scroll-and-a11y-improvements
Open

fix: restore window scrolling on main grid, optimize scroll-to-top, and enhance a11y & link security#69
zarifnexus wants to merge 1 commit into
juxtopposed:mainfrom
zarifnexus:fix/grid-scroll-and-a11y-improvements

Conversation

@zarifnexus

Copy link
Copy Markdown

Summary of Changes

This PR resolves layout and scrolling constraints on the main card grid, streamlines the scroll-to-top behavior, and enhances link security and accessibility.

1. Restore Natural Window Scrolling

  • Removed max-height: 70vh; and overflow-y: scroll; from .main-grid in public/global.css.
  • Cards now flow naturally within the main viewport, eliminating awkward inner scrollbars and restoring standard window scrolling.

2. Optimize Scroll-to-Top Component

  • Refactored src/scrollToTop.svelte to listen and scroll on window directly.
  • Removed redundant and error-prone document.querySelector('.main-grid') queries.
  • Added accessible attributes (role="button", tabindex="0", and aria-label="Back to top").

3. Security & A11y Improvements

  • Added rel="noopener noreferrer" to all external outbound target="_blank" links in src/Category.svelte and src/Modal.svelte.
  • Replaced aria-selected with aria-current on category buttons in src/Sidebar.svelte to fix the Svelte compiler a11y warning.

Verification

  • Built project with npm run build — 0 compiler errors and 0 warnings.
  • Tested category navigation, modal view, deep link routing, and smooth window scrolling.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

@zarifnexus is attempting to deploy a commit to the juxtopposed's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant