Check if query names are unique across jobs#150
Open
dewey wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that query names are unique across jobs to prevent conflicts in Prometheus metrics.
- Introduces a validation loop to detect duplicate query names.
- Aborts exporter initialization with a descriptive error when duplicates are found.
| for _, job := range cfg.Jobs { | ||
| for _, query := range job.Queries { | ||
| if _, ok := uniqueQueries[query.Name]; ok { | ||
| duplicateQueries = append(duplicateQueries, query.Name) |
There was a problem hiding this comment.
Duplicate query names may be appended multiple times if encountered repeatedly, resulting in redundant entries in the error message.
Suggested change
| duplicateQueries = append(duplicateQueries, query.Name) | |
| if _, added := addedDuplicates[query.Name]; !added { | |
| duplicateQueries = append(duplicateQueries, query.Name) | |
| addedDuplicates[query.Name] = struct{}{} | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.