Repository navigation
Pin CI actions, widen CodeQL, and update tap dependencies - #6
Merged
Merged
Conversation
The required status checks live in a repository ruleset, not in a file: adding or removing a CI job means editing the ruleset's context list too.
A Dependabot PR merged with squash produces a commit on main that is authored by Dependabot, so the workflow on it gets a read-only token and the SARIF upload 403s, failing the run. The analyze step now asks the action not to publish for a Dependabot-authored push. The pull_request path is left alone: code scanning allows uploading there because the results are scoped to that one pull request.
SHA pinning made Dependabot a weekly event, so the procedure for merging its pull request belongs in the repo: merge-commit rather than squash, and the REST endpoint rather than gh pr merge for the review bypass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a repository-wide switch to pin all external GitHub Actions to full 40-character commit SHAs, with release tags in trailing comments, as a supply-chain security measure. It updates all workflow files to use SHA-pinned references for
actions/checkoutandactions/upload-artifact, and updates documentation and comments to reflect the new convention and its implications. The CodeQL workflow is further improved to exclude test code from analysis and to handle Dependabot PR merges more robustly.Action Pinning and Workflow Security
All external actions in workflow files (
actions/checkout,actions/upload-artifact,github/codeql-action/initandanalyze) are now pinned to immutable commit SHAs with release tags as comments, following a new convention described in.github/dependabot.yml. This mitigates the risk of tag retargeting and supply-chain attacks. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12].github/dependabot.ymland workflow comments are extensively updated to document the SHA-pinning policy, its rationale, the trade-offs (e.g., loss of Dependabot security alerts for SHA-pinned actions), and the required review/merge procedures for Dependabot PRs. [1] [2]CodeQL Workflow Improvements
.github/workflows/codeql.yml) is updated to:doctest) from the analysis set by settingTETHERKIT_BUILD_TESTS=OFFduring the build, reducing noise from vendored code and focusing analysis on shipped code.pushevents, avoiding failures due to read-only tokens, while ensuring uploads still occur for PR runs.Other Notable Changes
HOMEBREW_TAP_TOKENsecret instead of the previous deploy key, further tightening security around tap publishing.Documentation and Comment Updates
These changes collectively strengthen the security and maintainability of the repository’s CI/CD workflows.