Skip to content

reduce copies in bjson encode #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justjake merged 1 commit into from
Jul 23, 2026
Merged

reduce copies in bjson encode #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions c/interface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,14 +1537,24 @@ void QTS_RuntimeDisableModuleLoader(JSRuntime *rt) {
JS_SetModuleLoaderFunc(rt, NULL, NULL, NULL);
}

// Frees a buffer that was handed off to an ArrayBuffer created with
// JS_NewArrayBuffer. The buffer was allocated by QuickJS (JS_WriteObject), so
// it must be released through the runtime allocator.
static void qts_free_bjson_buffer(JSRuntime *rt, void *opaque, void *ptr) {
js_free_rt(rt, ptr);
}

JSValue *QTS_bjson_encode(JSContext *ctx, JSValueConst *val) {
size_t length;
uint8_t *buffer = JS_WriteObject(ctx, &length, *val, JS_WRITE_OBJ_REFERENCE);
if (!buffer)
return jsvalue_to_heap(JS_EXCEPTION);

JSValue array = JS_NewArrayBufferCopy(ctx, buffer, length);
js_free(ctx, buffer);
// Transfer ownership of the buffer to the ArrayBuffer instead of copying it.
// QuickJS will call qts_free_bjson_buffer when the ArrayBuffer is collected.
JSValue array = JS_NewArrayBuffer(ctx, buffer, length, qts_free_bjson_buffer, NULL, false);
if (JS_IsException(array))
js_free(ctx, buffer);
return jsvalue_to_heap(array);
}

Expand Down
Loading