Conversation
…nd bb8 to 0.9" This reverts commit 0354854.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the diesel 2.3 bump from #91, which #95 reverts.
Not ready to merge. This is held open deliberately so the work is not lost
and does not need rewriting. It should land only once hyperswitch has moved off
diesel 2.2.10 — see #95 for why:
deja-dieselis compiled into hosts that pintheir own diesel, and the trait surface it wraps is exempt from diesel's semver
promise, so this pin has to move with the host rather than ahead of it.
What has to be true before merging
2.3.x,async-bb8-diesel 0.3.0andbb8 0.9(today on
mainit resolves 2.2.10 / 0.2.1 / 0.8.6)set_prepared_statement_cache_size— re-added here — is present on theConnectiontrait of whichever diesel version the host lands onMechanics. #91 is merged, and GitHub does not allow reopening a merged pull
request, so this is a new one carrying the same change. Sanchith's original
branch
bump-diesel-2.3was deleted on merge and has been restored atd1b9a9c, so the original commits remain reachable.This is stacked on
revert/diesel-2.3-bump(#95) so its diff shows only thebump; when #95 merges, GitHub retargets this to
mainautomatically.🤖 Generated with Claude Code
https://claude.ai/code/session_01DKdRsRrGsLYJ2bE7rRpvK6