feat(routing): dashboard parity for connector labels, amount note, and rule deletion - #410
Merged
Merged
Conversation
…inor-unit amounts
A merchant running several accounts of one connector saw identical rows
("adyen / mca_…" twice) in the gateway dropdowns, with only the MCA id to
tell them apart. The Hyperswitch dashboard hand-off already carries each
account's connector_label, so surface it: the picker now shows the label
beside the connector name (dropped when it merely repeats the name), and
typing filters on the label too.
The rule builder also gains the same smallest-currency-unit note the
Hyperswitch dashboard shows on its rule builder — amount conditions are
matched in minor units, and without the note a 100x mistake is easy.
Requested in juspay/hyperswitch-control-center#5495 (items 5 and 6).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jagan-jaya
previously approved these changes
Sep 4, 2026
…ashboard The Hyperswitch dashboard cannot delete routing rules (no delete endpoint exists in hyperswitch), so offering deletion only here left the two dashboards inconsistent (juspay/hyperswitch-control-center#5495, item 4). Comment out the /routing/delete route, and hide the Delete actions on the rules, volume-split, and A/B testing pages behind a RULE_DELETION feature flag so nothing dangles in the UI. Re-enabling is one flag flip plus uncommenting the route, once both dashboards can offer deletion. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
prajjwalkumar17
changed the title
3 of 10 tasks
#410 removes the /routing/delete route and hides the Delete UI action (RULE_DELETION flag) for parity with the Hyperswitch dashboard, but the E2E suite still asserted deletion succeeds — so every deletion test 404'd. Update them to the new contract: the delete route 404s and the rule survives (API), the lifecycle stops at deactivate, and the Delete menu action is absent rather than merely disabled (UI). The flaky analytics panel test passed on retry and is unrelated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jagan-jaya
approved these changes
Sep 11, 2026
AnkitKmrGupta
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three dashboard-parity fixes requested in juspay/hyperswitch-control-center#5495 (items 4, 5, and 6):
Connector labels in the gateway picker (item 5). A merchant running several accounts of one connector saw identical dropdown rows (
adyen / mca_…twice) with only the MCA id to tell them apart. The Hyperswitch dashboard hand-off already carries each account'sconnector_label(control-center PR feat: deep-link cut-over routing to the Decision Engine with the profile's connectors hyperswitch-control-center#5466), so the picker now shows it beside the connector name and lets the search filter match it. Labels that merely repeat the connector name are dropped so a row never reads "stripe stripe". Standalone (non-hand-off) usage is unchanged — catalogue options carry no label.Minor-unit amount note in the rule builder (item 6). The Hyperswitch dashboard warns that amounts are entered in the smallest currency unit (cents for USD, yen for JPY); this rule builder had no such note, inviting 100× mistakes in amount conditions. The same note now sits under "Configured Rules".
Rule deletion disabled (item 4). The Hyperswitch dashboard cannot delete routing rules (hyperswitch has no delete endpoint), so offering deletion only here left the two dashboards inconsistent. The
/routing/deleteroute is commented out insrc/app.rs, and the Delete actions on the rules, volume-split, and A/B testing pages are hidden behind aRULE_DELETIONfeature flag (off) so nothing dangles in the UI. Re-enabling is one flag flip plus uncommenting the route, once both dashboards can offer deletion. Nothing else calls the route — hyperswitch never uses/routing/delete.How tested
npx tsc --noEmitclean;vite buildclean.GatewaySelectin an isolated harness with hand-off options: two same-connector accounts are distinguishable by label, long labels truncate without breaking the row, typing a label fragment filters to the matching account, and label-less options render exactly as before.delete_routing_rulehandler stayspubin the lib crate, so no dead-code warning.Screen.Recording.2026-09-09.at.14.29.35.mov