Skip to content

perf: update hidden display cursor #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeeEirc merged 1 commit into from
Jul 29, 2026
Merged

perf: update hidden display cursor #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/tunnel/replay_part_upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
// api finish time
if _, err1 := p.ApiClient.SessionFinished(p.SessionId, p.replayMeta.DateEnd); err1 != nil {
logger.Errorf("PartUploader %s finish session error: %v", p.SessionId, err1)
return err
return err1
}
// write meta file
metaBuf, _ = json.Marshal(p.replayMeta)
Expand Down Expand Up @@ -377,7 +377,7 @@
if err != nil {
return scan, err
}
defer fd.Close()

Check failure on line 380 in pkg/tunnel/replay_part_upload.go

View workflow job for this annotation

GitHub Actions / lint 

Error return value of `fd.Close` is not checked (errcheck)
info, err := fd.Stat()
if err != nil {
return scan, err
Expand Down
1 change: 1 addition & 0 deletions ui/src/hooks/useGuacamoleClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ export function useGuacamoleClient(t: any) {

const handleMouseEnter = () => {
document.body.focus();
display.showCursor(false);
nextTick(() => {
sink.focus();
});
Expand Down
Loading