Add JSON.jl 1.x compatibility - #118
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 90.59% 92.20% +1.61%
==========================================
Files 5 5
Lines 287 539 +252
==========================================
+ Hits 260 497 +237
- Misses 27 42 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3e7a2c3 to
0230dd6
Compare
0230dd6 to
6b1485d
Compare
|
@davidanthoff or @pfitzseb, could you possibly review, please? |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| json-version: ["0.21", "1.7"] |
There was a problem hiding this comment.
Don't strictly need to run on JSON 1.x here since that gets picked up by the normal tests, but can't hurt I guess.
There was a problem hiding this comment.
We shouldn't put extra jobs into that workflow, that is really a template for the underlying shared workflow. We could use a second workflow file for this, or I'm also still thinking whether there is a good way to handle this natively in the testitem-workflow story.
I'll open a new PR doing whatever I come up with :)
Closes #99, and technically julia-vscode/LanguageServer.jl#1389 too.
For every PR, please check the following:
Related: