Skip to content

Add JSON.jl 1.x compatibility - #118

Merged
pfitzseb merged 2 commits into
julia-vscode:mainfrom
fromelicks:json-1-compat
Sep 1, 2026
Merged

Add JSON.jl 1.x compatibility#118
pfitzseb merged 2 commits into
julia-vscode:mainfrom
fromelicks:json-1-compat

Conversation

@fromelicks

@fromelicks fromelicks commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Closes #99, and technically julia-vscode/LanguageServer.jl#1389 too.

For every PR, please check the following:

Related:

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (2f1bc7f) to head (6b1485d).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/jsoncompat.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   90.59%   92.20%   +1.61%     
==========================================
  Files           5        5              
  Lines         287      539     +252     
==========================================
+ Hits          260      497     +237     
- Misses         27       42      +15     
Flag Coverage Δ
unittests 92.20% <94.44%> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fromelicks
fromelicks marked this pull request as ready for review August 31, 2026 09:44
@fromelicks fromelicks changed the title Add JSON 1 compatibility Add JSON.jl 1.x compatibility Aug 31, 2026
@fromelicks

fromelicks commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@davidanthoff or @pfitzseb, could you possibly review, please?

strategy:
fail-fast: false
matrix:
json-version: ["0.21", "1.7"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't strictly need to run on JSON 1.x here since that gets picked up by the normal tests, but can't hurt I guess.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't put extra jobs into that workflow, that is really a template for the underlying shared workflow. We could use a second workflow file for this, or I'm also still thinking whether there is a good way to handle this natively in the testitem-workflow story.

I'll open a new PR doing whatever I come up with :)

@pfitzseb
pfitzseb merged commit b157461 into julia-vscode:main Sep 1, 2026
236 of 254 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants