Forward max-workers to julia-run-testitems - #8
Merged
Conversation
`julia-run-testitems` has had a `max-workers` input all along, but this workflow never passed one through, so a repository using it has no way to bound the number of test processes — even though its four siblings (`threads`, `gc-between-testitems`, `memory-threshold`, `schedule`) are all forwarded. DebugAdapter.jl needs it: on Julia 1.0 there is no precompile cache locking, and on Windows a `.ji` file that another process holds open cannot be replaced, so as soon as that package has more than one test item the processes race and whichever loses reports `Cannot write cache file`.
davidanthoff
added a commit
to julia-vscode/DebugAdapter.jl
that referenced
this pull request
Aug 19, 2026
Julia 1.0 has no precompile cache locking, and on Windows a `.ji` that another process holds open cannot be replaced. This package had exactly one test item, so one test process started and nothing raced; adding the debug session tests makes several start together, all loading JuliaInterpreter, and whichever loses dies with "Cannot write cache file". Nothing in the package can fix that, so CI now runs the test items one at a time — they take seconds each, so it costs nothing. Requires julia-testitems/testitem-workflow#8, which forwards `max-workers` to `julia-run-testitems`; the action has always accepted it, the workflow just never passed one through. The README documented only the four-positional form of `debug_code`, and the README is what people actually read, so it now covers `notify_termination` too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
julia-actions/julia-run-testitemshas had amax-workersinput all along (action.yml, forwarded tojuliati --max-workers), but this workflow never passed one through — so a repository using it has no way to bound the number of test processes. Its four siblingsthreads,gc-between-testitems,memory-thresholdandscheduleare all forwarded already, so this looks like a plain omission rather than a decision.Two lines: the input, and the forward next to
threads. Default is"", so every existing caller is unaffected.Note on the original motivation, which no longer applies. I opened this to work around a Windows + Julia 1.0 precompile race in DebugAdapter.jl. That diagnosis was wrong: TestItemControllers already serializes environment activation precisely so the test environment is precompiled once, and the real bug was that on Julia 1.0–1.8 that window built nothing, because only the TestEnv variants for 1.9 and later finish
activatewithPkg._auto_precompile. That is fixed at the source in julia-testitems/TestItemControllers.jl#66, and DebugAdapter needs nomax-workerssetting.So this PR now stands purely on its own merits — filling in a forwarding gap — rather than as a fix for anything. Happy to close it if you would rather not add the knob.
🤖 Generated with Claude Code