Skip to content

Declare Logging in the test target - #81

Merged
davidanthoff merged 1 commit into
mainfrom
logging-testdep-and-comment
Aug 21, 2026
Merged

Declare Logging in the test target#81
davidanthoff merged 1 commit into
mainfrom
logging-testdep-and-comment

Conversation

@davidanthoff

Copy link
Copy Markdown
Member

Logging is missing from the test target

test/test_worker_lifecycle.jl does using Logging, but Logging is in neither [extras] nor the test target, so Pkg.test() always ends in:

ArgumentError: Package Logging not found in current path
  at test/test_worker_lifecycle.jl:235

That is the test item "A slow environment activation is reported while it is still running" — which covers the activation_progress_seconds warning added in this same unreleased cycle. So that test has never actually run.

Two side effects worth naming:

  • Because it is the last thing the suite prints, this error gets re-investigated as a regression during unrelated work. It is the reason the suite cannot be judged by "did Pkg.test() error" and has to be diffed against a baseline instead.
  • It costs a real test item's worth of coverage on a feature that is otherwise untested.

A comment correction

The timeout diagnostics from #77 carry a comment I got wrong. It reads:

Guarded by isdefined because the compat bound still allows a JSONRPC without the accessor.

There is no compat bound. TestItemControllers vendors JSONRPC (packages/JSONRPC, included from src/TestItemControllers.jl and testprocess/TestItemServer/src/pkg_imports.jl) rather than depending on it, so what actually decides whether outbound_backlog exists is when packages/JSONRPC was last re-vendored. The guard itself is correct and stays — it costs nothing and tolerates a partially-updated tree.

Testing

Not run locally — CI covers it, and this branch is based on current main, so its run also exercises the JSONRPC 3.0.2 re-vendor.

Two things to be aware of when reading the CI result, neither caused by this PR:

  • main has been red since before the re-vendor. test_process_crash.jl:Controlled crash via exit() failed at 5d596f407 (ubuntu 1.12.7~x86, windows 1.12.7~x64) and again at 751fa3750 (ubuntu 1.12.7~x64, windows 1.12.7~x86). Different legs each time, same test — a flaky-test signature that predates both Log which channel failed when a test item times out #77 and the re-vendor, and probably deserves its own issue.
  • test_jsonrpc_controller.jl has a timing-dependent assertion count (measured 65–84 on an unchanged tree), because it loops for n in started … @test and how many notifications land inside its sleep window varies. A differing count there is not a regression.

🤖 Generated with Claude Code

`test/test_worker_lifecycle.jl` does `using Logging`, but `Logging` was
in neither `[extras]` nor the `test` target, so `Pkg.test()` always ended
in

    ArgumentError: Package Logging not found in current path

at test_worker_lifecycle.jl:235 — "A slow environment activation is
reported while it is still running". That test item has therefore never
run, and the error has been repeatedly re-investigated as a regression
during unrelated work because it is the last thing the suite prints.

Also corrects a comment I got wrong in the timeout diagnostics: it said
the `isdefined` guard around `outbound_backlog` was there because "the
compat bound still allows a JSONRPC without the accessor". There is no
compat bound — TestItemControllers vendors JSONRPC rather than depending
on it, so what decides whether the accessor exists is when
`packages/JSONRPC` was last re-vendored. The guard itself is right and
stays.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@davidanthoff
davidanthoff merged commit 1ea2190 into main Aug 21, 2026
3 of 5 checks passed
@davidanthoff
davidanthoff deleted the logging-testdep-and-comment branch August 21, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant