Declare Logging in the test target - #81
Merged
Merged
Conversation
`test/test_worker_lifecycle.jl` does `using Logging`, but `Logging` was
in neither `[extras]` nor the `test` target, so `Pkg.test()` always ended
in
ArgumentError: Package Logging not found in current path
at test_worker_lifecycle.jl:235 — "A slow environment activation is
reported while it is still running". That test item has therefore never
run, and the error has been repeatedly re-investigated as a regression
during unrelated work because it is the last thing the suite prints.
Also corrects a comment I got wrong in the timeout diagnostics: it said
the `isdefined` guard around `outbound_backlog` was there because "the
compat bound still allows a JSONRPC without the accessor". There is no
compat bound — TestItemControllers vendors JSONRPC rather than depending
on it, so what decides whether the accessor exists is when
`packages/JSONRPC` was last re-vendored. The guard itself is right and
stays.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loggingis missing from the test targettest/test_worker_lifecycle.jldoesusing Logging, butLoggingis in neither[extras]nor thetesttarget, soPkg.test()always ends in:That is the test item "A slow environment activation is reported while it is still running" — which covers the
activation_progress_secondswarning added in this same unreleased cycle. So that test has never actually run.Two side effects worth naming:
Pkg.test()error" and has to be diffed against a baseline instead.A comment correction
The timeout diagnostics from #77 carry a comment I got wrong. It reads:
There is no compat bound. TestItemControllers vendors JSONRPC (
packages/JSONRPC, included fromsrc/TestItemControllers.jlandtestprocess/TestItemServer/src/pkg_imports.jl) rather than depending on it, so what actually decides whetheroutbound_backlogexists is whenpackages/JSONRPCwas last re-vendored. The guard itself is correct and stays — it costs nothing and tolerates a partially-updated tree.Testing
Not run locally — CI covers it, and this branch is based on current
main, so its run also exercises the JSONRPC 3.0.2 re-vendor.Two things to be aware of when reading the CI result, neither caused by this PR:
mainhas been red since before the re-vendor.test_process_crash.jl:Controlled crash via exit()failed at5d596f407(ubuntu 1.12.7~x86,windows 1.12.7~x64) and again at751fa3750(ubuntu 1.12.7~x64,windows 1.12.7~x86). Different legs each time, same test — a flaky-test signature that predates both Log which channel failed when a test item times out #77 and the re-vendor, and probably deserves its own issue.test_jsonrpc_controller.jlhas a timing-dependent assertion count (measured 65–84 on an unchanged tree), because it loopsfor n in started … @testand how many notifications land inside its sleep window varies. A differing count there is not a regression.🤖 Generated with Claude Code