Skip to content

Do not end the debug session after a setup snippet #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidanthoff merged 2 commits into from
Aug 19, 2026
Merged

Do not end the debug session after a setup snippet #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d03a7
Do not end the debug session after a setup snippet
davidanthoff Aug 19, 2026
c0b20fd
Merge branch 'main' into fix-debug-with-setup
davidanthoff Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion testprocess/TestItemServer/src/TestItemServer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@
setup_details = state.test_setups[(params.packageUri, Symbol(i))]

if setup_details.kind==:module && !setup_details.evaled
mod = Core.eval(Main.Testsetups, :(module $(Symbol(i)) end))

Check warning on line 647 in testprocess/TestItemServer/src/TestItemServer.jl

View workflow job for this annotation

GitHub Actions / julia-ci / lint

missing_reference 

Missing reference: Testsetups

code = string('\n'^(setup_details.line-1), ' '^(setup_details.column-1), setup_details.code)

Expand Down Expand Up @@ -797,7 +797,12 @@
withpath(testsnippet_filepath) do
if mode == "Debug"
debug_session = wait_for_debug_session()
DebugAdapter.debug_code(debug_session, mod, testsnippet_code, testsnippet_filepath)
# A setup snippet is not the last thing this session debugs — the
# test item's own body follows — and `terminated` would tell the
# client the debuggee has ended, so it would disconnect before the
# body ran and no breakpoint in the item would ever be hit
# (julia-testitems/TestItemRunner.jl#107).
DebugAdapter.debug_code(debug_session, mod, testsnippet_code, testsnippet_filepath; notify_termination=false)
else
mode == "Coverage" && clear_coverage_data()
# A snippet is re-evaluated into every item's scope, so its output
Expand Down
Loading