TestEnv: port merge-project guard to Julia <=1.10 variants - #56
Draft
davidanthoff wants to merge 1 commit into
Draft
TestEnv: port merge-project guard to Julia <=1.10 variants#56davidanthoff wants to merge 1 commit into
davidanthoff wants to merge 1 commit into
Conversation
The Julia 1.11+ variant of the vendored TestEnv tolerates the package's own uuid already being present in the working manifest when merging the test manifest; the 1.4/1.7/1.8/1.9 variants still raised "can not merge projects" unconditionally. That breaks packages whose test/Manifest.toml dev's the package itself (path = "..") on Julia <= 1.10. Port the guard to the older variants, add the TestManifestPackage fixture and a regression test that runs it on the current Julia and, under the comprehensive_platform tag, on Julia 1.10. Refs julia-vscode/julia-vscode#3832, julia-vscode/julia-vscode#3633 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
davidanthoff
marked this pull request as draft
August 19, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/TestEnv/src/julia-1.11/activate_set.jl) guards the "can not merge projects" error: it only fires when the working manifest already holds a different entry for the uuid and that uuid is not the package under test. Thejulia-1.4/1.7/1.8/1.9variants still had the unguardedhaskey(working_manifest, uuid)check, so a package with atest/Manifest.tomlthat lists the package itself as apath = ".."dev entry (the layoutPkg.develop(path=".")insidetest/produces) failed activation on Julia <= 1.10 test processes withcan not merge projects. Fixes the TIC side of still on 1.144.2: TestItems testing stuck on (Queued) julia-vscode/julia-vscode#3832 and Battling to run and debug @testitem test julia-vscode/julia-vscode#3633.prune_manifest(sandbox_manifest, [uuid])kept as-is; theSet([uuid])form is 1.12+ only).julia-1.0..1.3do not contain the pattern and are untouched.testdata/TestManifestPackage(package +test/Project.toml+ committedtest/Manifest.tomlformat 2.0 dev-ing the package viapath = "..";.gitignoregets a negation for that one manifest) andtest/test_test_manifest.jlwith two test items: one running the fixture on the current Julia, one tagged:comprehensive_platformrunning it on the Julia 1.10 juliaup channel viaTestHelpers.isolated_depot_env, liketest_julia_versions.jl.Same change proposed upstream at JuliaTesting/TestEnv.jl (see linked PR).
Test plan
TestEnv.activate()on the fixture fails withcan not merge projectsusing the vendored copy onmain, succeeds with this branch.test/test_test_manifest.jl(both items, i.e. current Julia 1.12.7 and Julia 1.10.12 test process) andtest/test_run_passing.jlrun locally viaTestItemRunner.run_testswith a filename filter: 16/16 pass.🤖 Generated with Claude Code