Conversation
Major progress was made. I gave up and slammed cursor AI on the case. Vibe coded or not. There's a limit to my sanity and understanding of cpus and things.
--- updated-dependencies: - dependency-name: SharpCompress dependency-version: 0.48.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot #26 bumps SharpCompress 0.29.0 → 0.48.0 (GHSA-6c8g-7p36-r338). 0.45+ renamed ArchiveFactory.Open to OpenArchive; CI failed with CS0117. Co-authored-by: Julian R <julerobb1@users.noreply.github.com>
julerobb1
marked this pull request as ready for review
August 29, 2026 02:57
Owner
Author
|
Closing as stale branch cleanup. ExtraROM leftover dest-live on PR #30 is the only active work; keeping main, dev, and cursor/load-etc-extrarom-2404. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot already opened the SharpCompress security bump as #26 (
0.29.0→0.48.0, targetingmain). That PR is not merge-ready: Production Release CI failed with:This follow-up is based on that bump and only fixes the 0.45+/0.48.0 call-site rename:
ArchiveFactory.Open(archivePath)→ArchiveFactory.OpenArchive(archivePath)No second Dependabot-style bump PR. Extraction options (
ExtractFullPath/Overwrite) andWriteToDirectoryremain valid on 0.48.0.Base:
dev(retargeted frommain; branch rebased onto currentdevso the diff is only the SharpCompress bump + compile fix).Alert this closes
WriteToDirectorypath traversal (zip-slip variant)<= 0.47.40.48.0(this PR keeps the Dependabot version)Change
ProcessorEmulator.csproj0.29.0→0.48.0(from #26)ArchiveExtractor.csArchiveFactory.Open→OpenArchive(compile fix)Unrelated packages are unchanged. Extraction logic is not rewritten.
Verification
net8.0compile of the SharpCompress call sites against 0.48.0 succeeded.submit-nugetstill fails withNETSDK1100(Linux restore ofnet8.0-windows). That is the same pre-existing GitHub Dependency Submission failure as Bump SharpCompress from 0.29.0 to 0.48.0 #26, not a SharpCompress API break.Please close or supersede #26 in favor of this follow-up.