Completed Component Library#3
Conversation
|
|
|
thesudeshdas
left a comment
thesudeshdas
left a comment
There was a problem hiding this comment.
I've suggested some changes, make them and you can merge the development branch to the main branch
| @@ -0,0 +1,1606 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
mobile responsive view is breaking, the right margin is more than left margin
| <body id="body"> | ||
| <div class="main"> | ||
| <!-- start of the navbar --> | ||
| <nav class="navbar"> |
There was a problem hiding this comment.
Navigation brand name is breaking in mobile view
| </span> | ||
| Lorem ipsum | ||
| <span class="product-info__small" | ||
| >Lorem ipsum dolor sit Lorem</span |
| <div | ||
| class="container--border container--margin responsive--container" | ||
| > | ||
| <div class="flex--container"> |
There was a problem hiding this comment.
some classes have -- in between, whereas some have __, is it a convention?
There was a problem hiding this comment.
yes, -- is a modifier, __ is a block
| </p> | ||
| </div> | ||
| <footer class="modal__article__footer"> | ||
| <button |
There was a problem hiding this comment.
hovering on the button makes the button same color as that of background. Make it a different color for readability
| @@ -0,0 +1,58 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I couldn't access this landing page from anywhere.
| <!-- start of the container --> | ||
| <div class="container"> | ||
| <!-- start of the sidebar--> | ||
| <div class="sidebar"> |
There was a problem hiding this comment.
sidebar doesn't appear on mobile view
There was a problem hiding this comment.
yet not implement for mobile.
| <body id="body"> | ||
| <div class="main"> | ||
| <!-- start of the navbar --> | ||
| <nav class="navbar"> |
There was a problem hiding this comment.
make navbar sticky? it'll look much better and it's better for navigation through the site
| height="32" | ||
| /> | ||
| </div> | ||
| <pre> |
There was a problem hiding this comment.
prism code is having a scrollbar on the right side, unnecessary
This reverts commit 85943bb.
4 participants
Guys, Please Review My Component Library.