🎨 Palette: Improve library loading feedback and upgrade build system#7
🎨 Palette: Improve library loading feedback and upgrade build system#7juankyc wants to merge 1 commit into
Conversation
This PR implements a micro-UX improvement for the sample application and upgrades the build system for Java 21 compatibility. 💡 What: - Updated `onUnitTestLoadClick` in `MainActivity.java` to disable the load button and change its text once `libhookee2.so` is loaded. - Added a `Toast` message for visual confirmation of library loading. - Upgraded Gradle to 8.5 and AGP to 8.2.2. - Set `javaVersion` to `1.8` and removed the deprecated `android.disableAutomaticComponentCreation` property. 🎯 Why: - Provides clear feedback to the user that the library has been loaded successfully. - Prevents redundant clicks on the "Load Library" button. - Build system upgrades are required to support the Java 21 environment in this repository. ♿ Accessibility: - Uses string resources for the updated button state. - Button state change (disabling) helps screen readers understand the action is no longer available. The UX changes are localized to ~10 lines of code, adhering to the Palette persona's constraints. Co-authored-by: juankyc <150547187+juankyc@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR implements a micro-UX improvement for the sample application and upgrades the build system for Java 21 compatibility.
💡 What:
onUnitTestLoadClickinMainActivity.javato disable the load button and change its text oncelibhookee2.sois loaded.Toastmessage for visual confirmation of library loading.javaVersionto1.8and removed the deprecatedandroid.disableAutomaticComponentCreationproperty.🎯 Why:
♿ Accessibility:
The UX changes are localized to ~10 lines of code, adhering to the Palette persona's constraints.
PR created automatically by Jules for task 5442543782844569372 started by @juankyc