refactor(examples): retrofit draw-room with countdown's synced clock - #51
Merged
Conversation
Split out of the countdown-plugin PR per review: draw-room gains a shared countdown rendered from the plugin's exported statics, drops the name-entry trial for auto join-order labels, re-pins to preview SHA 7b1d96a, and uses pluginAPI.update(). Adds the draw-room section to examples/README.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts: # examples/draw-room.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retrofits
examples/draw-room.htmlwith a synchronized group countdown rendered fromplugin-multiplayer-countdown's exported statics (startedAtKey/resolveStartedAt/computeRemaining/formatTime) — the plugin's "synced timer during another trial" use-case, live in a real demo. Also simplifies the demo's lobby: the name-entrysurvey-texttrial is replaced with automatic join-order labels ("Player 1", "Player 2"), and the roster reads from those. Adds adraw-room.htmlsection toexamples/README.md(previously missing).Split out of #41 per review feedback, so that PR stays a pure "add the countdown package" change.
Merge ordering
plugin-multiplayer-countdown/dist). Until feat: add plugin-multiplayer-countdown (synchronized group timer) #41 merges, this PR's diff shows feat: add plugin-multiplayer-countdown (synchronized group timer) #41's commits too.draw-room.htmlhunk: this rewrite already pins preview SHA7b1d96aand usespluginAPI.update()for the done-flag. If chore(examples): re-pin jsPsych preview build to latest #3694 commit #44 lands first, the merge conflict here resolves by taking this version; chore(examples): re-pin jsPsych preview build to latest #3694 commit #44's chat-room/ultimatum re-pins are unaffected.🤖 Generated with Claude Code