(Breaking) Get String List#12
Open
ineanto wants to merge 20 commits into
Open
Conversation
Owner
|
Hey, thanks for the PR. I will review it and respond later this week. |
Owner
|
Can you update your branch with the latest from master |
Author
Hello! I'm quite busy this week but I'll keep you posted |
Author
|
Hi. I merged with upstream and bumped to version 1.3.0 inside the README file according to the Gradle build file! Edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I had initially intended to keep this build to myself but I'm opening this pull request in sight of the requests to introduce a
getStringList()method. I'm fully aware that in addition to the new method, I've made a number of (questionable) breaking changes.These include:
staticmethods (READMEfor further information)If those changes don't follow the vision you have for this project, I'm fully ok with you rejecting this pull request.
Thank you! (Fixes #11)