fix: make xml shortcut match text/xml and application/xml (Fixes #24) - #112
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Map the xml type shorthand to both application/xml and text/xml so is/request checks treat both as valid XML content types. Fixes jshttp#24 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new TypeIs(['xml'])did not matchtext/xmlbecause thexmlshorthand was not mapped inDEFAULT_LOOKUP.Both
application/xmlandtext/xmlare valid XML types, so map the shortcut to both.TypeIsalready expandsstring[]fromnormalize— no other API change.Fixes #24
Test plan
xmlmatches bothapplication/xmlandtext/xml(TypeIs#request,TypeIs#is, andnormalize)npm test— 315 passed (prettier + tsc + vitest)