Harden npm release preflight - #5
Merged
Merged
Conversation
Owner
Author
|
Release state after the partial 0.2.0 publish:
Recommended order to finish 0.2.0 cleanly:
This PR prevents future additions of brand-new package names from partially publishing other packages first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NPM_TOKENand a package name does not yet exist on npmWhy
The 0.2.0 release partially published
@jrkropp/codex-jsbefore npm rejected the new@jrkropp/codex-js-reactpackage. npm trust configuration requires the package to already exist on the registry, so new package names need a token/manual bootstrap before OIDC-only releases are safe.Validation
pnpm format:checkpnpm lintpnpm release:preflightNPM_TRUSTED_PUBLISHING=true pnpm release:preflightfails intentionally for the missing React packageNPM_TOKEN=dummy NPM_TRUSTED_PUBLISHING=true pnpm release:preflightpasses