feat(datasets): pick a storage connection in the create-dataset modal - #653
Merged
Conversation
…ataset
Add a storage-connection selector to the "New dataset" modal. On org
change the modal loads the org's storage connections from
GET /organizations/{org_id}/storage-connections and offers them in a
dropdown. Selecting one passes `connection` (id) to the create endpoint,
which the API resolves to a managed upload target (source_type=managed,
source_uri derived from the connection's bucket/prefix). "None" keeps
the existing reference-only behavior. The Source URI input is disabled
when a connection is chosen since the API sets it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "New dataset" modal now lets the user choose a storage connection as the dataset's managed upload target.
GET /organizations/{org_id}/storage-connectionsand lists them in a dropdown (name · purpose · bucket, flags the default).connection(the connection id) toPOST /orgs/{org_id}/datasets. The API already resolves this to a managed target (source_type=managed,source_uriderived from the connection's bucket/prefix).Why
Backend supported
DatasetCreate.connectionalready; the frontend had no way to set it. This wires the picker into the modal.Files
src/web/src/hooks/useDatasets.ts—connection?onCreateDatasetInput, sent in POST bodysrc/web/src/pages/Datasets.tsx—ConnOptiontype, per-org connection fetch, selector, source-URI gatingTest
No local typecheck —
typescriptnot installed on this host (prod web is a prebuilt static image). Relies on CItsc -b.🤖 Generated with Claude Code