Improve corrections table with "Zeroer" category#226
Conversation
Such as standaline fitzpatricks, 🏼🏽🏾🏿 etc are width 0, 'narrower' only covered "usually wide characters are narrow", we need additional 'zeroer' case for terminals like this.
Merging this PR will degrade performance by 17.18%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_wcstwidth_wide_term_program[ghostty] |
561.1 µs | 732.5 µs | -23.39% |
| ❌ | test_wcstwidth_vs15_term_program[ghostty] |
679.7 µs | 759.1 µs | -10.46% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing jq/bugfix-more-than-narrow (be5b4b8) with master (9df7261)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
===========================================
- Coverage 100.00% 99.89% -0.11%
===========================================
Files 27 27
Lines 1924 1938 +14
Branches 456 458 +2
===========================================
+ Hits 1924 1936 +12
- Misses 0 1 +1
- Partials 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Improve correction tables with 'zeroer'
Such as standaline fitzpatricks, 🏼🏽🏾🏿 etc are width 0, 'narrower'
only covered "usually wide characters are narrow", we need additional
'zeroer' case for terminals like this.