Skip to content

Improve corrections table with "Zeroer" category#226

Open
jquast wants to merge 3 commits into
masterfrom
jq/bugfix-more-than-narrow
Open

Improve corrections table with "Zeroer" category#226
jquast wants to merge 3 commits into
masterfrom
jq/bugfix-more-than-narrow

Conversation

@jquast
Copy link
Copy Markdown
Owner

@jquast jquast commented Jun 5, 2026

Improve correction tables with 'zeroer'

Such as standaline fitzpatricks, 🏼🏽🏾🏿 etc are width 0, 'narrower'
only covered "usually wide characters are narrow", we need additional
'zeroer' case for terminals like this.

jquast added 2 commits June 5, 2026 18:19
Such as standaline fitzpatricks, 🏼🏽🏾🏿 etc are width 0, 'narrower'
only covered "usually wide characters are narrow", we need additional
'zeroer' case for terminals like this.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 5, 2026

Merging this PR will degrade performance by 17.18%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 106 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_wcstwidth_wide_term_program[ghostty] 561.1 µs 732.5 µs -23.39%
test_wcstwidth_vs15_term_program[ghostty] 679.7 µs 759.1 µs -10.46%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing jq/bugfix-more-than-narrow (be5b4b8) with master (9df7261)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.89%. Comparing base (9df7261) to head (be5b4b8).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
wcwidth/_constants.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #226      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files           27       27              
  Lines         1924     1938      +14     
  Branches       456      458       +2     
===========================================
+ Hits          1924     1936      +12     
- Misses           0        1       +1     
- Partials         0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant