Lift Koin out of ConferenceMaterialTheme#1695
Merged
Merged
Conversation
Make ConferenceMaterialTheme a pure Composable that takes useDynamicColor and darkThemeConfig as parameters. The settings lookup moves into a new ConferenceMaterialThemeFromSettings wrapper, so the theme function itself no longer requires a Koin container and can render under previews/tests without one. Production call sites (ConferenceView, ConferenceCard, iOS SessionDetailsViewController) switch to the wrapper to preserve existing behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConferenceMaterialThemeto takeuseDynamicColoranddarkThemeConfigas plain parameters with sensible defaults; remove the in-themekoinInjectandLocalInspectionModebranch.ConferenceMaterialThemeFromSettingswrapper that performs the Koin lookup (with aLocalInspectionModefallback) and forwards plain values into the pure theme function.ConferenceView,ConferenceCard, iOSSessionDetailsViewController) to the wrapper so behaviour is preserved.Motivation:
ConferenceMaterialThemewas reaching into Koin viacurrentKoinScope(), which made it unrenderable in any context that hadn't run the consumer Application'sonCreate(notably the wearApp'sThemePreview, whereConferenceCardtransitively pulled in the shared theme). With the DI lookup moved into the wrapper, the theme function itself is self-contained and preview-safe.Test plan
./gradlew :shared:compileDebugKotlinAndroid— clean build (only pre-existing deprecation warnings).ConferenceViewand per-card theming behave as before.SessionDetailsViewControllerstill themes correctly.wearAppThemePreview(Compose preview / screenshot test) — should no longer require a started Koin container.